Thin email tools around Mailozaurr services

[PrzemyslawKlys]

Summary

• thin the email pack so session setup and IMAP message reading live in Mailozaurr
• remove local IMAP/SMTP factories from IntelligenceX.Tools.Email
• depends on Move reusable email session helpers into Mailozaurr Mailozaurr#596

Validation

• dotnet build IntelligenceX.Tools/IntelligenceX.Tools.Email/IntelligenceX.Tools.Email.csproj -c Release -p:MailozaurrRoot=C:\Support\GitHub_wt\mailozaurr-tools-thin-phase2-email\
• dotnet test IntelligenceX.Tools/IntelligenceX.Tools.Tests/IntelligenceX.Tools.Tests.csproj -c Release --no-restore -p:BuildProjectReferences=false -p:MailozaurrRoot=C:\Support\GitHub_wt\mailozaurr-tools-thin-phase2-email\ --filter FullyQualifiedName~EmailSmtpProbeStrictModeTests

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9396bd1033

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[intelligencex-review]

IntelligenceX Review

Reviewing PR #1190: Thin email tools around Mailozaurr services
Reviewed commit: 1b0cd94

Merge blockers: items in Todo List ✅ and Critical Issues ⚠️ sections (if present). Other Issues 🧯 are suggestions.

Summary 📝

Refactor generally looks clean and moves session setup into Mailozaurr as intended. I did not find a clear merge-blocking defect in the diff. Main behavior changes are in EmailImapGetTool result shaping and SMTP error fallback handling; both look reasonable, but there are a couple maintainability/correctness edge cases worth tightening.

Todo List ✅

None.

Other Issues 🧯

• IntelligenceX.Tools/IntelligenceX.Tools.Email/EmailImapGetTool.cs: CreateSummaryPreview truncates by UTF-16 character count, while body truncation now happens inside ImapMessageReader by MaxBodyBytes; the preview may therefore exceed a strict byte-oriented display limit for non-ASCII text. Rationale: mixed truncation semantics can make output size less predictable.
• IntelligenceX.Tools/IntelligenceX.Tools.Email/EmailImapGetTool.cs: the tool now trusts ImapMessageReader to normalize nulls for Subject, From, To, Folder, and bodies, but the old code explicitly coalesced to empty strings. Rationale: if the upstream service returns nulls, serialized output/summary formatting may change unexpectedly.
• IntelligenceX.Tools/IntelligenceX.Tools.Email/EmailSessionRequests.cs: BuildSmtpSessionRequest and ApplySmtpRuntimeOptions split SMTP configuration across two methods. Rationale: duplicated setup paths are easier to drift out of sync as options evolve.
• IntelligenceX.Tools/IntelligenceX.Tools.Email/Properties/AssemblyInfo.cs: adding InternalsVisibleTo is fine for tests, but it broadens the test assembly’s access to internals across the project. Rationale: this increases coupling and makes internal API changes harder to contain.

Tests / Coverage 🧪

• Added tests cover the new helper methods, but there is still no direct regression coverage for the behavior change in EmailImapGetTool output mapping from Mailozaurr’s ImapMessageReader.
• Consider adding one focused test for null/empty field normalization in the IMAP get result model and one for SMTP connect/auth failure fallback error codes/messages.

Next Steps 🚀

• Merge is reasonable as-is.
• Consider adding the two regression tests above to lock down the changed integration contract with Mailozaurr.

Static Analysis Policy 🧭

• Config mode: respect
• Packs: All Essentials (50)
• Rules: 108 enabled
• Rule list display: up to 10 items per section
• Enabled rules preview: CA2000 (Dispose objects before losing scope), CA1062 (Validate arguments of public methods), SA1600 (Elements should be documented), CA1016 (Mark assemblies with assembly version), CA1018 (Mark attributes with AttributeUsageAttribute), CA1041 (Provide ObsoleteAttribute message), CA1047 (Do not declare protected member in sealed type), CA1050 (Declare types in namespaces), CA1061 (Do not hide base class methods), CA1067 (Override Object.Equals(object) when implementing IEquatable<T>) (truncated)
• Result files: 2 input patterns, 1 matched, 1 parsed, 0 failed
• Status: pass
• Rule outcomes: 0 with findings, 108 clean
• Failing rules: none
• Clean rules: CA2000 (Dispose objects before losing scope), CA1062 (Validate arguments of public methods), SA1600 (Elements should be documented), CA1016 (Mark assemblies with assembly version), CA1018 (Mark attributes with AttributeUsageAttribute), CA1041 (Provide ObsoleteAttribute message), CA1047 (Do not declare protected member in sealed type), CA1050 (Declare types in namespaces), CA1061 (Do not hide base class methods), CA1067 (Override Object.Equals(object) when implementing IEquatable<T>) (truncated)
• Outside-pack rules: none

Static Analysis 🔎

• Findings: 0 (no issues at or above configured severity)

Model & Usage 🤖

• Model: gpt-5.4
• Length: medium
• Mode: hybrid
• Reasoning: not configured
• Usage: 5h limit: 96% remaining | weekly limit: 45% remaining | code review weekly limit: 2% remaining | credits: 0