Fix post-merge CI regressions

[PrzemyslawKlys]

Summary

• align preview/plan CLI and MCP tests with case-sensitive confirmation-token normalization
• preserve isolated MSAL cache paths during tests so net8.0 and net472 runners do not share the same cache file
• keep the merged main branch green after PR Preserve message id casing in confirmation tokens #601

Verification

• dotnet build Sources/Mailozaurr.sln -c Debug
• dotnet test Sources/Mailozaurr.Tests/Mailozaurr.Tests.csproj -c Debug --filter "ApplicationMessageActionPlanServiceTests|ApplicationMessageActionPlanRegistryServiceTests|CliRunnerTests|MailMcpToolsTests|TokenCacheHelperTests|ApplicationMessageActionPreviewServiceTests|ApplicationRoutingServicesTests"
• dotnet test Sources/Mailozaurr.sln -c Debug --no-build --verbosity minimal --logger "console;verbosity=minimal"

[claude]

Claude finished @PrzemyslawKlys's task —— View job

---

PR Review Complete

I've analyzed the changes in this post-merge CI regression fix. Here's my comprehensive review:

Todo List

• Read repository guidelines (CLAUDE.md)
• Analyze TokenCacheHelper.cs changes
• Review test file modifications
• Check for code quality and best practices
• Identify potential bugs or issues
• Assess performance considerations
• Review security concerns
• Evaluate test coverage
• Provide final recommendations

---

Overall Assessment ✅ Looks Good

This PR effectively addresses the CI regressions from PR #601 with focused, well-designed changes.

Key Changes Summary

1. Case-Sensitive Token Normalization: Updated test expectations to align with StringComparer.Ordinal instead of StringComparer.OrdinalIgnoreCase
2. MSAL Cache Isolation: Added environment variable support to prevent test runner cache conflicts

Detailed Review

🔧 Code Quality & Best Practices

Excellent - The changes follow established patterns and maintain consistency:

• Clean, single-responsibility changes
• Proper use of environment variables for configuration
• Good test isolation practices with unique cache paths per test process
• Consistent string comparison semantics across the codebase

🐛 Bug Prevention

Strong - No bugs identified, changes improve reliability:

• Fixes case sensitivity inconsistencies that could cause test flakiness
• Resolves cache sharing issues between test runners
• Proper cleanup in TokenCacheHelperTests.Dispose()

⚡ Performance

Neutral - No performance impact:

• StringComparer.Ordinal is actually slightly faster than OrdinalIgnoreCase
• Cache path resolution adds minimal overhead (simple environment variable lookup)

🛡️ Security

Good - Maintains security without introducing risks:

• Environment variable for cache path allows secure test isolation
• No hardcoded paths or secrets exposed
• Maintains same file permission model as before

🧪 Test Coverage

Comprehensive - Tests properly cover the changes:

• All affected test files updated consistently
• TokenCacheHelperTests enhanced with proper isolation using process ID and GUID
• Tests verify both case sensitivity and cache isolation

Specific Technical Notes

TokenCacheHelper.cs (Sources/Mailozaurr/Authentication/TokenCacheHelper.cs:130-140)

private static string ResolveCacheFilePath() {
    var overriddenPath = Environment.GetEnvironmentVariable(CachePathEnvironmentVariable);
    if (!string.IsNullOrWhiteSpace(overriddenPath)) {
        return overriddenPath.Trim();
    }
    // fallback to default path...
}

• Good: Clean separation of concerns with environment variable override
• Good: Proper null/whitespace checking and trimming
• Good: Maintains backward compatibility with existing behavior

Test Isolation (Sources/Mailozaurr.Tests/TokenCacheHelperTests.cs:14-17)

var directory = Path.Combine(Path.GetTempPath(), "Mailozaurr.Tests", "TokenCache", 
                            Process.GetCurrentProcess().Id.ToString(), Guid.NewGuid().ToString("N"));

• Excellent: Uses process ID + GUID for complete isolation between parallel test runs
• Good: Proper cleanup in Dispose() method
• Good: Prevents net8.0 and net472 runners from sharing cache files

Case Sensitivity Changes

Multiple files show changes from StringComparer.OrdinalIgnoreCase to StringComparer.Ordinal:

• Correct: Aligns with the confirmation token normalization changes from PR Preserve message id casing in confirmation tokens #601
• Consistent: Applied uniformly across all affected test files
• Expected: Test count changes from 1→2 reflect proper case-sensitive unique message counting

Recommendations

✅ Approve as-is

This PR is well-executed and ready for merge:

1. Focused scope: Changes are minimal and targeted
2. Proper testing: All modifications include corresponding test updates
3. Clear intent: Directly addresses the stated CI regression issues
4. No side effects: Changes maintain existing functionality while fixing specific issues

🚀 Optional Future Enhancements

Consider for future PRs (not blocking):

1. Documentation: Add XML comments to ResolveCacheFilePath() explaining the override behavior
2. Configuration: Consider centralizing test configuration constants
3. Logging: Could add debug logging for cache path resolution in development builds

---

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.11%. Comparing base (42741cc) to head (7c994cb).
⚠️ Report is 5 commits behind head on v2-speedygonzales.

Files with missing lines	Patch %	Lines
...rces/Mailozaurr/Authentication/TokenCacheHelper.cs	50.00%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##           v2-speedygonzales     #603      +/-   ##
=====================================================
- Coverage              51.13%   51.11%   -0.02%     
=====================================================
  Files                    473      473              
  Lines                  31170    31176       +6     
  Branches                5359     5360       +1     
=====================================================
- Hits                   15938    15935       -3     
- Misses                 13268    13277       +9     
  Partials                1964     1964              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.