Add maximum marking#4156
Open
schnellerhase wants to merge 24 commits intomainfrom
Open
Conversation
275ba33 to
6c6adf9
Compare
6c6adf9 to
60086aa
Compare
jhale
previously requested changes
Apr 20, 2026
chrisrichardson
approved these changes
Apr 21, 2026
Member
|
My comments on the floating point comparisons are not resolved. |
Contributor
|
@jhale - I think @schnellerhase did address it. Did you mean that it should be a simple |
Member
|
Yes - the equality is completely redundant in a floating point context and the example given is a contrived one. |
jorgensd
reviewed
Apr 23, 2026
|
|
||
| msh.topology.create_entities(1) | ||
| marked_edges = mesh.compute_incident_entities(msh.topology, marked_cells, tdim, 1) | ||
| mesh.refine(msh, marked_edges) |
Member
There was a problem hiding this comment.
Should there be something more at the end of this test ?
Contributor
Author
There was a problem hiding this comment.
I just wanted to check that the input works as expected with the refine calls - so the test being "refine works". Not sure what to exactly test for on the refined mesh, up to it being a mesh.
jhale
requested changes
Apr 24, 2026
schnellerhase
commented
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a maximum marking criterion for AFEM schemes, i.e. for$\theta \in (0, 1)$ and a marker $\eta \in \mathbb{R}^N$ , computes
In particular this introduces/defines the interface for other marking routines (to follow in the future): based on a process local list of (entity-)indicators the (local) marked index set of it is computed.
Test program to visualise results (parallel ready).
Work towards #4141.