Skip to content

Add mixed-topology support to locate_dofs_topological #4167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpdean wants to merge 26 commits into
base: main
Choose a base branch
from
+240 −63

Index type

df9bf8e
Select commit
Loading
Failed to load commit list.
Open

Add mixed-topology support to locate_dofs_topological #4167

Index type
df9bf8e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 21, 2026 in 1m 32s

Quality Gate passed

Issues
22 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 256 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "num_cell_types" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2wVvw19oD0_rp7MSzV&open=AZ2wVvw19oD0_rp7MSzV&pullRequest=4167

Check warning on line 47 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'const int' 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2wYINLuW9FAmBCVj7z&open=AZ2wYINLuW9FAmBCVj7z&pullRequest=4167

Check warning on line 425 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "num_entity_types" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2wVvw19oD0_rp7MSza&open=AZ2wVvw19oD0_rp7MSza&pullRequest=4167

Check warning on line 106 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "and" with "&&". 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2wHWmg1bH6TsjJLbkQ&open=AZ2wHWmg1bH6TsjJLbkQ&pullRequest=4167

Check warning on line 320 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a enumerator "cell" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjq&open=AZ2vxYgMsJSu0Mk_zXjq&pullRequest=4167

Check warning on line 128 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use std::format instead of concatenating pieces manually. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjo&open=AZ2vxYgMsJSu0Mk_zXjo&pullRequest=4167

Check warning on line 468 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a enumerator "cell" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXju&open=AZ2vxYgMsJSu0Mk_zXju&pullRequest=4167

Check warning on line 269 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2wVvw19oD0_rp7MSzY&open=AZ2wVvw19oD0_rp7MSzY&pullRequest=4167

Check warning on line 285 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjp&open=AZ2vxYgMsJSu0Mk_zXjp&pullRequest=4167

Check warning on line 114 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::find" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjn&open=AZ2vxYgMsJSu0Mk_zXjn&pullRequest=4167

Check warning on line 339 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a enumerator "cell" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjr&open=AZ2vxYgMsJSu0Mk_zXjr&pullRequest=4167

Check warning on line 429 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjt&open=AZ2vxYgMsJSu0Mk_zXjt&pullRequest=4167

Check warning on line 269 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use std::format instead of concatenating pieces manually. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2wVvw19oD0_rp7MSzZ&open=AZ2wVvw19oD0_rp7MSzZ&pullRequest=4167

Check warning on line 74 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjg&open=AZ2vxYgMsJSu0Mk_zXjg&pullRequest=4167

Check warning on line 86 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXji&open=AZ2vxYgMsJSu0Mk_zXji&pullRequest=4167

Check warning on line 86 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use std::format instead of concatenating pieces manually. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjj&open=AZ2vxYgMsJSu0Mk_zXjj&pullRequest=4167

Check warning on line 110 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a enumerator "cell" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjm&open=AZ2vxYgMsJSu0Mk_zXjm&pullRequest=4167

Check warning on line 264 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "num_entity_types" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2wVvw19oD0_rp7MSzW&open=AZ2wVvw19oD0_rp7MSzW&pullRequest=4167

Check warning on line 417 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "num_cell_types" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjs&open=AZ2vxYgMsJSu0Mk_zXjs&pullRequest=4167

Check warning on line 74 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use std::format instead of concatenating pieces manually. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjh&open=AZ2vxYgMsJSu0Mk_zXjh&pullRequest=4167

Check warning on line 282 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'const int' 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2vxYgMsJSu0Mk_zXjf&open=AZ2vxYgMsJSu0Mk_zXjf&pullRequest=4167

Check warning on line 260 in cpp/dolfinx/fem/DirichletBC.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ2wVvw19oD0_rp7MSzX&open=AZ2wVvw19oD0_rp7MSzX&pullRequest=4167
View more details on SonarQubeCloud