pimd: prefer kernel ingress on WRONGVIF when MFC iif is stale (backport #22607)#22624
Merged
Conversation
When interfaces with duplicate or overlapping connected addresses cause join-time RPF to pick the wrong interface, the kernel keeps delivering WRONGVIF after the MFC is installed. Extend the existing NOCACHE ingress-prefer logic to the WRONGVIF handler so upstream RPF and MFC iif realign with the interface the packet actually arrived on. If zebra still selects a different RPF interface but the kernel ingress is connected to the source, force RPF and MFC iif onto that ingress so overlapping connected prefixes (e.g. parent secondary vs PIM-passive tunnel) can recover. Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com> (cherry picked from commit 45affe6)
Add a topotest that installs FHR state on a parent interface with an overlapping secondary, then moves traffic onto a PIM-passive tunnel stand-in so MFC iif is stale and WRONGVIF must realign to kernel ingress. Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com> (cherry picked from commit 92b4de8)
|
Target branch is not in the allowed branches list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When interfaces with duplicate addresses cause join-time RPF to pick the wrong interface, the kernel keeps delivering WRONGVIF after the MFC is installed. Extend the existing NOCACHE ingress-prefer logic to the WRONGVIF handler so upstream RPF and MFC iif realign with the interface the packet actually arrived on.
This is an automatic backport of pull request #22607 done by Mergify.