Codex/fix macos native network plugin#17
Closed
moni11811 wants to merge 9 commits into
Closed
Conversation
Author
|
Only in LAN mode, Network works up until printing Trying to get it working |
Author
Looks like they've added some server side rejection?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes macOS Bambu networking failures from issue #5.
macOS now uses the native Bambu network plugin by default. The Linux bridge stays opt-in via
PJARCZAK_LINUX_BRIDGE_ENABLED.Also fixes the macOS quit crash by shutting down
BBLNetworkPluginduringGUI_App::OnExit()before wx/AppKit process exit.Aligned the macOS media-state constant fix with upstream PR #12.
No breaking changes expected.
Screenshots/Recordings/Graphs
Printer connected through Bambu Handy and appeared in OrcaSlicer on macOS.
Tests
git diff --check./Applications/OrcaSlicer.app.