macOS build: AppleClang 21 fix + workflow artifact sync + Lima README#26
Draft
TomKalina wants to merge 2 commits into
Draft
macOS build: AppleClang 21 fix + workflow artifact sync + Lima README#26TomKalina wants to merge 2 commits into
TomKalina wants to merge 2 commits into
Conversation
- README: add Lima/Rosetta prerequisites for macOS bridge runtime
- workflows: sync .github/workflows/{build_macos,build_windows}_bridge.yml with the de-collided artifact names already staged at repo root (linux_host_runtime_macos_* / _windows_*)
AppleClang 21 (Xcode 26+) enforces the C++20 rule that out-of-enum-range casts are not constant expressions. wxMediaState's max value is 2, so (wxMediaState)6 is no longer constexpr. Mirrors the static inline const + static_cast pattern already used in MediaPlayCtrl.h:74.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wxMediaCtrl2.hconstexpr error on AppleClang 21 (Xcode 26+) — out-of-enum-range cast no longer a constant expression in C++20; mirror thestatic inline const+static_castpattern already used inMediaPlayCtrl.h:74.github/workflows/build_{macos,windows}_bridge.ymlwith the de-collided artifact names already staged at repo root (linux_host_runtime_macos_*/_windows_*) somy_build_all.ymldoesn't fail on artifact-name collision when macOS + Windows run in parallelTest plan
build_release_macos.sh -d -x -a arm64 -t 11.3)OrcaSlicer --help, exits 0)build_macos_bridge.ymlgreen end-to-end (Linux bridge job + arm64 + x86_64 + universal DMG)build_windows_bridge.ymlstill green after artifact rename