Guard empty printer preview loading for issues #6 and #25#29
Open
ShredderAlex wants to merge 3 commits into
Open
Guard empty printer preview loading for issues #6 and #25#29ShredderAlex wants to merge 3 commits into
ShredderAlex wants to merge 3 commits into
Conversation
|
Thanks for the PR! Just a note: the core issue in #6 and #25 (on Linux/Wayland) is actually a missing The fix is a two-line backport from SoftFever's commit c0ae2bd (details in #6). This PR may fix a separate crash for users with an empty |
Author
|
Thanks for the feedback, bitbarista. The suggested fix has now been applied. Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR guards printer preview loading when printertype or printermodel is empty, preventing the crash/incorrect loading state described in issue #6 and the slow/failed filament selection behavior in issue #25.
Screenshots/Recordings/Graphs
None.
Tests
Not run; this is a targeted logic fix.