implement core::error::Error#244
Merged
Merged
Conversation
MathiasKoch
marked this pull request as draft
December 16, 2025 08:13
MathiasKoch
marked this pull request as ready for review
December 16, 2025 08:13
Member
|
This seems reasonable. Thank you for the contribution, and sorry for the long review time. Could you rebase to re-trigger the CI? |
by using thiserror
johann-cm
force-pushed
the
impl_error
branch
from
December 16, 2025 09:13
d9175da to
c398400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the
core::error::Errortrait to better integrate the atat Error enums into the rust error system.My use case: be able to use the
#[from]attribute to derive an error enum for my application: