Skip to content

implement core::error::Error#244

Merged
MathiasKoch merged 1 commit into
FactbirdHQ:masterfrom
johann-cm:impl_error
Dec 16, 2025
Merged

implement core::error::Error#244
MathiasKoch merged 1 commit into
FactbirdHQ:masterfrom
johann-cm:impl_error

Conversation

@johann-cm

Copy link
Copy Markdown
Contributor

Implement the core::error::Error trait to better integrate the atat Error enums into the rust error system.

My use case: be able to use the #[from] attribute to derive an error enum for my application:

#[derive(Debug, Error)]
pub enum MyApplicationError {
    #[error("AT error: {0}")]
    ATError(#[from] atat::Error),
    ...
}

@MathiasKoch
MathiasKoch marked this pull request as draft December 16, 2025 08:13
@MathiasKoch
MathiasKoch marked this pull request as ready for review December 16, 2025 08:13
@MathiasKoch

Copy link
Copy Markdown
Member

This seems reasonable. Thank you for the contribution, and sorry for the long review time.

Could you rebase to re-trigger the CI?

by using thiserror
@MathiasKoch
MathiasKoch merged commit 6845479 into FactbirdHQ:master Dec 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants