fix(mqtt): Surface clean-session reconnect on Subscription::next_message#123
Merged
Conversation
…opics Bump the QoS on the request/response topic pairs from AtMostOnce to AtLeastOnce so a transient drop between SUBSCRIBE and the broker's reply doesn't silently lose the response and park the caller forever.
Only invalidate Subscriptions when the broker actually drops our subs (CONNACK with session_present=false). Transient disconnects and session-resume reconnects keep subs valid. - mqttrust backend: bump rev to pick up FactbirdHQ/mqttrust#XX, which surfaces the same signal via clean_session_count. - rumqttc backend: track a watch::Sender<u8> bumped only on session_present=false; subscriptions race recv against changed(). Replaces the over-aggressive "any state change → None" behavior. - Trait doc clarified. Refs #121
MathiasKoch
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MqttSubscription::next_messagereturnsNonewhen the broker has dropped our subs (CONNACK withsession_present=false), so callers can resubscribe.clean_session_count.watch::Sender<u8>counter bumped only onsession_present=falseCONNACKs. Replaces the previous over-aggressive "any state change → None".Test plan
wait_deltareturnsNone→ caller resubscribes.Fixes #121