feat(__init__.py): update version to 1.25.1 for future release#1295
Open
David-GERARD wants to merge 1 commit intomasterfrom
Open
feat(__init__.py): update version to 1.25.1 for future release#1295David-GERARD wants to merge 1 commit intomasterfrom
David-GERARD wants to merge 1 commit intomasterfrom
Conversation
Contributor
Author
|
@yjhan96 this is important as I hadn't done it previously leading to pypi displaying the wrong release tag (1.24.4 instead of 1.25.0), so for future releases we must make sure to check that the pettingzoo/init.py has been updated. Same goes for SuperSuit. |
Collaborator
|
It looks like SB3/waterworld tutorial test is failing due to a SuperSuit-related error. Once we fix that, this should be good to merge. |
7 tasks
Contributor
|
I think I fixed the waterworld test issue with a PR in the supersuit repo @yjhan96 or @David-GERARD can you check the supersuit PR and merge if it looks good? Hopefully that will fix the issue with this PR and #1297 |
Collaborator
|
Hi @dm-ackerman - I approved the PR you made in SuperSuit. Once that's merged, we can fix this PR's issue, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changing the version to 1.25.1 for future release. This is required for pypi to display the right version after publishing a release on GitHub and execution of the build-publish workflow.
Type of change