Skip to content

Return reset and step output in base wrapper#1310

Open
Mark2000 wants to merge 1 commit intoFarama-Foundation:masterfrom
Mark2000:patch-1
Open

Return reset and step output in base wrapper#1310
Mark2000 wants to merge 1 commit intoFarama-Foundation:masterfrom
Mark2000:patch-1

Conversation

@Mark2000
Copy link
Copy Markdown

@Mark2000 Mark2000 commented Oct 2, 2025

Description

The base wrapper doesn't return the result of reset and step, contrary to the expected behavior for the API.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dm-ackerman
Copy link
Copy Markdown
Contributor

The base wrapper is for the AEC API which does not return anything for step() and reset(). You might be looking for BaseParallelWrapper which uses the Parallel API, which does return values from step() and reset()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants