Proposal: Split interpolation implementations into separate files#1189
Proposal: Split interpolation implementations into separate files#1189gijswl wants to merge 3 commits intoFerrite-FEM:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1189 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 39 48 +9
Lines 6436 6436
=======================================
Hits 6043 6043
Misses 393 393 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I also already thought about this, but was not sure what a good policy to group them could look like, as too fine granularity can also be problematic if the number of interpolation keeps growing. The implemented ones were added to the abstract type to improve visibility to what is implemented already. Also, should the resulting commit for this PR be ignored for history? |
|
Split based on conformity could make sense. Ignore history would be good.
I've had a thought to define a tuple/vector of implemented interpolations. That could automate testing, enable documenting which cases are implemented etc. |
|
For me, that split could be alright too, but it will as Dennis says lead to many small files which is a bit inconsistent with how the rest of the repo is organized. Perhaps @fredrikekre has some opinion here? |
|
I don't mind the long file but this split is ok too. |
While working on the Nedelec and RT interpolations, I found it was quite difficult to move around the large
interpolations.jlfile (it being approx. 2000 lines). My proposal would be to put each interpolation family into its own file to improve maintainability.Besides that, some interpolations were missing from the list of implemented interpolations. I've added these to the docstring of each family.
Thoughts?