-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/roles and ban system (#32) #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,18 @@ | ||
| from sqlalchemy.orm import declarative_base | ||
| from fastapi import Request | ||
| from sqlalchemy.ext.asyncio import ( | ||
| AsyncSession, | ||
| async_sessionmaker | ||
| ) | ||
|
|
||
| Base = declarative_base() | ||
|
|
||
| async def get_db(request: Request): | ||
|
|
||
| async with request.app.state.SessionLocal() as session: | ||
| try: | ||
| SessionLocal: async_sessionmaker[AsyncSession] | None = None | ||
|
|
||
| async def get_db(): | ||
| if SessionLocal is None: | ||
| raise RuntimeError("Database is not initialied") | ||
| async with SessionLocal() as session: | ||
| yield session | ||
| finally: | ||
| await session.close() | ||
|
|
||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| from sqlalchemy import update | ||
| from datetime import datetime, timezone | ||
|
|
||
| from src.domain.models.ban_model import Ban | ||
| from src.infrastructure.db.database import SessionLocal | ||
|
|
||
| async def remove_expired_bans(): | ||
| async with SessionLocal() as db: | ||
| await db.execute(update(Ban).where( | ||
| Ban.expires_at.is_not(None), | ||
| Ban.expires_at < datetime.now(timezone.utc), | ||
| Ban.revoked_at.is_(None) | ||
| ).values( | ||
| revoked_at = datetime.now(timezone.utc), | ||
| revoked_reason="Expiration of the Term" | ||
| ) | ||
| ) | ||
|
|
||
| await db.commit() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Используйте поддерживаемый API остановки планировщика вместо
dispose()и обеспечьте корректное управление его жизненным циклом.В APScheduler 3.x у
AsyncIOSchedulerнет методаdispose(), поэтому при завершении работы будет выброшенAttributeError. Вместо этого используйтеscheduler.shutdown(wait=False)(илиwait=True, если нужно дождаться завершения задач). Поскольку планировщик является синглтоном на уровне модуля, также важно гарантировать, что его остановка идемпотентна и чтоstart()/shutdown()не могут быть вызваны в неверном порядке (например, в тестах или при перезапуске приложения).Original comment in English
issue (bug_risk): Use the scheduler’s supported shutdown API instead of
dispose()and ensure proper lifecycle handling.AsyncIOSchedulerin APScheduler 3.x doesn’t havedispose(), so this will raiseAttributeErroron teardown. Usescheduler.shutdown(wait=False)(orwait=Trueif needed) instead. Since the scheduler is a module-level singleton, also ensure shutdown is idempotent and thatstart()/shutdown()can’t be called in an inconsistent order (e.g., across tests or reloads).