Refactor the modelLoader and fix a small bug#4838
Merged
Merged
Conversation
Also fix an issue where if MODEL_LIST_CONFIG_JSON is set, but does not exist, fallback did not work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR refactors the modelLoader.ts to remove a bunch of duplicated code. It now has one function for fetching the model from url or disk and the other functions just make use of that.
I also fixed a bug where if
MODEL_LIST_CONFIG_JSONwas set but didn't exist, it'd silently load no models. It feels like this should fall back to the default models in the same way that the URL fetch failure does.