Skip to content

Fix(agentflow) - Fix z-index for validation button#6238

Merged
j-sanaa merged 3 commits into
mainfrom
fix/agentflow-z-index
Apr 16, 2026
Merged

Fix(agentflow) - Fix z-index for validation button#6238
j-sanaa merged 3 commits into
mainfrom
fix/agentflow-z-index

Conversation

@j-sanaa

@j-sanaa j-sanaa commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Before:
image

After:
image

  • Revert changes made to z-index of validation panel

@j-sanaa j-sanaa marked this pull request as ready for review April 16, 2026 22:23

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the zIndex values for the sparkles icon button and the canvas action buttons wrapper in Agentflow.tsx, reducing them from 1001 to 10. The review feedback points out that this change introduces a stacking conflict with the AddNodesDrawer, which may cause UI elements to overlap incorrectly. Additionally, the feedback notes that the zIndex on the action buttons wrapper is redundant and recommends using centralized constants instead of magic numbers to maintain a consistent stacking hierarchy.

Comment thread packages/agentflow/src/Agentflow.tsx Outdated
Comment thread packages/agentflow/src/Agentflow.tsx Outdated
@j-sanaa j-sanaa requested a review from jocelynlin-wd April 16, 2026 22:25

@mmattu-wd mmattu-wd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change! I think we should potentially explore a stack manager so we never have to define a zIndex manually again

@jocelynlin-wd jocelynlin-wd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this!

@j-sanaa j-sanaa merged commit 0fc44e6 into main Apr 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants