Skip to content

test: cover MCP tool call boundary#6625

Open
jw-ond wants to merge 1 commit into
FlowiseAI:mainfrom
jw-ond:codex/mcp-tool-call-boundary-tests
Open

test: cover MCP tool call boundary#6625
jw-ond wants to merge 1 commit into
FlowiseAI:mainfrom
jw-ond:codex/mcp-tool-call-boundary-tests

Conversation

@jw-ond

@jw-ond jw-ond commented Jul 14, 2026

Copy link
Copy Markdown

Summary

  • Add focused MCPTool tests for the execution-time MCP boundary.
  • Verify each tool invocation creates a per-call client with invocation headers and dispatches tools/call with the expected tool name and arguments.
  • Verify the per-call client is closed even when tools/call fails.

Context

Related to #6433. This does not implement a trust verifier hook; it locks down the current per-call execution contract so future verifier work can safely attach at the MCPTool() boundary without relying on cached discovery behavior.

Test

  • git diff --check
  • npx -y pnpm@10.26.0 --dir packages/components test -- nodes/tools/MCP/core.test.ts --runInBand

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds unit tests to core.test.ts to verify the behavior of the MCPTool call boundary. Specifically, it tests that invoking an MCPTool creates a per-call client with the correct invocation headers, dispatches the tools/call method, and ensures that the client is properly closed under both successful and failed execution paths. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant