test: cover MCP tool call boundary#6625
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds unit tests to core.test.ts to verify the behavior of the MCPTool call boundary. Specifically, it tests that invoking an MCPTool creates a per-call client with the correct invocation headers, dispatches the tools/call method, and ensures that the client is properly closed under both successful and failed execution paths. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
MCPTooltests for the execution-time MCP boundary.tools/callwith the expected tool name and arguments.tools/callfails.Context
Related to #6433. This does not implement a trust verifier hook; it locks down the current per-call execution contract so future verifier work can safely attach at the
MCPTool()boundary without relying on cached discovery behavior.Test
git diff --checknpx -y pnpm@10.26.0 --dir packages/components test -- nodes/tools/MCP/core.test.ts --runInBand