Fix pipeline#971
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to restore CI pipeline stability by updating failing unit tests and disabling E2E execution in GitHub Actions until E2E is addressed separately.
Changes:
- Updated multiple component unit tests in
packages/libto match current DOM structure, routing, and styling behavior. - Re-enabled the unit-test workflow job and commented out E2E execution in CI.
- Added a Vitest config for
packages/appwith workspace aliasing.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/lib/src/components/TablePagination/TablePagination.test.tsx | Adjusts pagination tests for Mantine/TanStack table + SearchableSelect behavior |
| packages/lib/src/components/PasswordStrengthIndicator/PasswordRequirement.test.tsx | Updates assertions to reflect current Tailwind class usage |
| packages/lib/src/components/Notification/HttpNotification.test.tsx | Updates portal handling by creating a #notification mount point and wrapping with MantineProvider |
| packages/lib/src/components/NavBar/NavBar.test.tsx | Adds i18n/pathname mocks and updates expected hrefs |
| packages/lib/src/components/Home/Home.test.tsx | Switches from router-mock navigation assertions to verifying callback usage |
| packages/lib/src/components/Header/Header.test.tsx | Updates spotlight search assertion to match button-based SearchBar |
| packages/lib/src/components/FeedbackWidget/FeedbackWidget.test.tsx | Adds disclosure mock/cleanup and adjusts queries for hidden elements |
| packages/lib/src/components/Contact/Contact.test.tsx | Updates layout and contact info assertions to match current roles/labels |
| packages/app/vitest.config.mts | Introduces Vitest config + aliases for app tests |
| .github/workflows/ci.yml | Pins pnpm, changes Node version, re-enables unit tests, and comments out E2E job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
f4-lex
reviewed
Apr 8, 2026
f4-lex
requested changes
Apr 8, 2026
f4-lex
approved these changes
Apr 14, 2026
…tion support in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Quick-fix for pipeline. Fix failing unit tests and skip e2e tests in pipeline till they are fixed as well (not this scope)
TO-DO
main& resolve merge conflicts