Skip to content

fix: clean up expired OAuth codes to prevent memory leak #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nanookclaw wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: clean up expired OAuth codes to prevent memory leak #43

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bae09b6
fix: clean up expired OAuth codes to prevent memory leak
nanookclaw May 10, 2026
da042c6
fix: stop OAuth cleanup worker on context cancel
nanookclaw May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion havril/internal/api/handlers/oauth_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,18 @@ type codeEntry struct {
}

func NewOAuthHandler(baseURL string, userRepo *user.Repository) *OAuthHandler {
return &OAuthHandler{baseURL: baseURL, userRepo: userRepo}
h := &OAuthHandler{baseURL: baseURL, userRepo: userRepo}
go func() {

@Freedisch Freedisch May 13, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this goroutine lacks an exit. in this current state there will be accumulation of goroutines if we have users multiple being login in

for range time.Tick(5 * time.Minute) {

@Freedisch Freedisch May 13, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should ensure that time.Tick is closed bcs it cannot be recovered by a garbage collector and will lead to more memory leaks

h.codes.Range(func(k, v any) bool {

@Freedisch Freedisch May 13, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding that, I feel like if have the DoS vector attack that can leak huge cpu spike not sure if my current vpc could handle that 😅

we can keep that for now

if time.Now().After(v.(*codeEntry).expiresAt) {
h.codes.Delete(k)
}
return true
})
}
}()
return h
}

// Metadata handles GET /.well-known/oauth-authorization-server
Expand Down