Skip to content

Fix CI test failures #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ADmad merged 6 commits into from
Feb 19, 2026
Merged

Fix CI test failures #431

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
950ebad
Fix CI test failures
dereuromark Feb 19, 2026
568d1ad
Require PHPUnit 10.5.58+ for CLI option compatibility
dereuromark Feb 19, 2026
39016b9
Fix deprecation error
ADmad Feb 19, 2026
1695a8d
Fix phpstan and phpcs errors
ADmad Feb 19, 2026
899bb25
Fix tests for CakePHP < 5.3
ADmad Feb 19, 2026
71bb10e
Remove uneeded directory existence check
ADmad Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Command/InstallCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,12 @@ public function linkPluginAssets(ConsoleIo $io): void
{
$io->info('Linking plugin assets...');

// Ensure the webroot directory exists before symlinking
if (!is_dir(WWW_ROOT)) {
Comment thread
dereuromark marked this conversation as resolved.
Outdated
$filesystem = new Filesystem();
$filesystem->mkdir(WWW_ROOT);
}

$result = $this->executeCommand(PluginAssetsSymlinkCommand::class, ['name' => 'BootstrapUI'], $io);
if (
$result !== static::CODE_SUCCESS &&
Expand Down
2 changes: 1 addition & 1 deletion tests/TestCase/Command/CopyLayoutsCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public function testHelp()
<info>Options:</info>

--help, -h Display this help.
--quiet, -q Enable quiet output.
--quiet, -q Enable quiet output and non-interactive mode.
--verbose, -v Enable verbose output.

<info>Arguments:</info>
Expand Down
68 changes: 12 additions & 56 deletions tests/TestCase/Command/InstallCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,6 @@ public function testInstall()
'<success>`bootstrap.bundle.js.map` successfully deleted.</success>',
'<success>`bootstrap.bundle.min.js` successfully deleted.</success>',
'<success>`bootstrap.bundle.min.js.map` successfully deleted.</success>',
'<success>`popper.js` successfully deleted.</success>',
'<success>`popper.js.map` successfully deleted.</success>',
'<success>`popper.min.js` successfully deleted.</success>',
'<success>`popper.min.js.map` successfully deleted.</success>',
'<success>`bootstrap-icons.css` successfully deleted.</success>',
'<success>`bootstrap-icons.woff` successfully deleted.</success>',
'<success>`bootstrap-icons.woff2` successfully deleted.</success>',
Expand All @@ -106,10 +102,6 @@ public function testInstall()
'<success>`bootstrap.bundle.js.map` successfully copied.</success>',
'<success>`bootstrap.bundle.min.js` successfully copied.</success>',
'<success>`bootstrap.bundle.min.js.map` successfully copied.</success>',
'<success>`popper.js` successfully copied.</success>',
'<success>`popper.js.map` successfully copied.</success>',
'<success>`popper.min.js` successfully copied.</success>',
'<success>`popper.min.js.map` successfully copied.</success>',
'<success>`bootstrap-icons.css` successfully copied.</success>',
'<success>`bootstrap-icons.woff` successfully copied.</success>',
'<success>`bootstrap-icons.woff2` successfully copied.</success>',
Expand All @@ -131,10 +123,6 @@ public function testInstall()
'<success>`bootstrap.bundle.js.map` successfully deleted.</success>',
'<success>`bootstrap.bundle.min.js` successfully deleted.</success>',
'<success>`bootstrap.bundle.min.js.map` successfully deleted.</success>',
'<success>`popper.js` successfully deleted.</success>',
'<success>`popper.js.map` successfully deleted.</success>',
'<success>`popper.min.js` successfully deleted.</success>',
'<success>`popper.min.js.map` successfully deleted.</success>',
'<success>`bootstrap-icons.css` successfully deleted.</success>',
'<success>`bootstrap-icons.woff` successfully deleted.</success>',
'<success>`bootstrap-icons.woff2` successfully deleted.</success>',
Expand All @@ -146,13 +134,10 @@ public function testInstall()
'<success>`bootstrap.bundle.js.map` successfully copied.</success>',
'<success>`bootstrap.bundle.min.js` successfully copied.</success>',
'<success>`bootstrap.bundle.min.js.map` successfully copied.</success>',
'<success>`popper.js` successfully copied.</success>',
'<success>`popper.js.map` successfully copied.</success>',
'<success>`popper.min.js` successfully copied.</success>',
'<success>`popper.min.js.map` successfully copied.</success>',
'<success>`bootstrap-icons.css` successfully copied.</success>',
'<success>`bootstrap-icons.woff` successfully copied.</success>',
'<success>`bootstrap-icons.woff2` successfully copied.</success>',
"Copied assets to directory $appWebrootPluginPath",
];
$this->assertEquals($notPresentInNonVerboseMode, array_values(array_diff($expected, $this->_out->messages())));
$this->assertExitCode(Command::CODE_SUCCESS);
Expand Down Expand Up @@ -244,45 +229,16 @@ public function testInstallVerbose()
{
$this->exec('bootstrap install -v');

$appWebrootPluginPath = WWW_ROOT . 'bootstrap_u_i';
$expected = [
'<info>Clearing `node_modules` folder (this can take a while)...</info>',
'<success>Cleared `node_modules` folder.</success>',
'<info>Installing packages...</info>',
'<success>`bootstrap.css` successfully deleted.</success>',
'<success>`bootstrap.css.map` successfully deleted.</success>',
'<success>`bootstrap.min.css` successfully deleted.</success>',
'<success>`bootstrap.min.css.map` successfully deleted.</success>',
'<success>`bootstrap.bundle.js` successfully deleted.</success>',
'<success>`bootstrap.bundle.js.map` successfully deleted.</success>',
'<success>`bootstrap.bundle.min.js` successfully deleted.</success>',
'<success>`bootstrap.bundle.min.js.map` successfully deleted.</success>',
'<success>`bootstrap-icons.css` successfully deleted.</success>',
'<success>`bootstrap-icons.woff` successfully deleted.</success>',
'<success>`bootstrap-icons.woff2` successfully deleted.</success>',
'<success>All buffered files cleared.</success>',
'<info>Installing packages...</info>',
'<success>`bootstrap.css` successfully copied.</success>',
'<success>`bootstrap.css.map` successfully copied.</success>',
'<success>`bootstrap.min.css` successfully copied.</success>',
'<success>`bootstrap.min.css.map` successfully copied.</success>',
'<success>`bootstrap.bundle.js` successfully copied.</success>',
'<success>`bootstrap.bundle.js.map` successfully copied.</success>',
'<success>`bootstrap.bundle.min.js` successfully copied.</success>',
'<success>`bootstrap.bundle.min.js.map` successfully copied.</success>',
'<success>`bootstrap-icons.css` successfully copied.</success>',
'<success>`bootstrap-icons.woff` successfully copied.</success>',
'<success>`bootstrap-icons.woff2` successfully copied.</success>',
'<success>All files buffered.</success>',
'<info>Removing possibly existing plugin assets...</info>',
'For plugin: BootstrapUI',
'<info>Linking plugin assets...</info>',
'For plugin: BootstrapUI',
"Copied assets to directory $appWebrootPluginPath",
'Done',
'<success>Installation completed.</success>',
];
$this->assertEmpty(array_diff($expected, $this->_out->messages()));
// Verify key messages are present (exact file list varies by bootstrap version)
$messages = $this->_out->messages();
$this->assertContains('<info>Clearing `node_modules` folder (this can take a while)...</info>', $messages);
$this->assertContains('<success>Cleared `node_modules` folder.</success>', $messages);
$this->assertContains('<info>Installing packages...</info>', $messages);
$this->assertContains('<success>All buffered files cleared.</success>', $messages);
$this->assertContains('<success>All files buffered.</success>', $messages);
$this->assertContains('<info>Removing possibly existing plugin assets...</info>', $messages);
$this->assertContains('<info>Linking plugin assets...</info>', $messages);
$this->assertContains('<success>Installation completed.</success>', $messages);
$this->assertExitCode(Command::CODE_SUCCESS);

$filesystem = new Filesystem();
Expand Down Expand Up @@ -818,7 +774,7 @@ public function testHelp()

--help, -h Display this help.
--latest, -l To install the latest minor versions of required assets.
--quiet, -q Enable quiet output.
--quiet, -q Enable quiet output and non-interactive mode.
--verbose, -v Enable verbose output.
"],
$this->_out->messages(),
Expand Down
2 changes: 1 addition & 1 deletion tests/TestCase/Command/ModifyViewCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ public function testHelp()
<info>Options:</info>

--help, -h Display this help.
--quiet, -q Enable quiet output.
--quiet, -q Enable quiet output and non-interactive mode.
--verbose, -v Enable verbose output.

<info>Arguments:</info>
Expand Down
Loading