Skip to content

fix(inline): four small bugs around the inline-consent flow #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skerbis merged 6 commits into from
Jun 12, 2026
Merged

fix(inline): four small bugs around the inline-consent flow #484

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
48c56eb
fix(inline): initialize $consentId and $serviceKey from fragment vars
marcohanke Jun 12, 2026
2f8df40
fix(inline): write cookie under same name that getStorageValue reads
marcohanke Jun 12, 2026
ad00341
feat(inline): implement documented css_class option
marcohanke Jun 12, 2026
103bcfb
fix(inline): make overlay cover the full placeholder by default
marcohanke Jun 12, 2026
90f56c6
refactor(inline): lazy-init consentId default
marcohanke Jun 12, 2026
e9c2f35
fix(inline): migrate legacy cookie on read so users keep their consent
marcohanke Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/consent_inline.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
--consent-overlay-border-radius: 8px;
--consent-overlay-border: 1px solid rgba(128, 128, 128, 0.2);
--consent-overlay-shadow: 0 4px 20px rgba(0, 0, 0, 0.1);
--consent-overlay-max-width: 90%;
--consent-overlay-max-width: 100%;

position: relative;
z-index: 2;
Expand Down Expand Up @@ -258,7 +258,7 @@
/* Mobile Variablen */
--consent-min-height: 250px;
--consent-overlay-padding: 1.5rem;
--consent-overlay-max-width: 95%;
--consent-overlay-max-width: 100%;
}

.consent-inline-content {
Expand Down
10 changes: 8 additions & 2 deletions assets/consent_inline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,9 +556,15 @@ if (typeof window.consentManagerInline !== 'undefined') {
this.clearOldConsentCookies();
}

// Legacy-Cleanup: in v5.6.6 und früher wurde das Cookie unter dem
// falschen Namen 'consent_manager' geschrieben, alle Read-Pfade
// verwendeten aber 'consentmanager'. Den alten Namen für betroffene
// User explizit löschen, damit nicht zwei parallele Cookies existieren.
document.cookie = 'consent_manager=; expires=' + new Date(0).toUTCString() + '; path=/';

// Setze das neue Cookie (neu und sauber)
document.cookie = 'consent_manager=' + JSON.stringify(data) +
'; expires=' + expires.toUTCString() +
document.cookie = 'consentmanager=' + JSON.stringify(data) +
'; expires=' + expires.toUTCString() +
'; path=/; SameSite=Lax';
},
Comment thread
marcohanke marked this conversation as resolved.

Expand Down
9 changes: 8 additions & 1 deletion fragments/ConsentManager/inline_placeholder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@
$options = $this->getVar('options', []);
$placeholderData = $this->getVar('placeholderData', []);
$content = $this->getVar('content', '');
$consentId = $this->getVar('consentId', uniqid('consent_', true));
$serviceKey = $this->getVar('serviceKey', '');
Comment thread
marcohanke marked this conversation as resolved.
Outdated

// Optionale CSS-Klasse (laut docs/inline.md unterstützt) an den Container hängen
$extraClass = (isset($options['css_class']) && is_string($options['css_class']) && '' !== $options['css_class'])
? ' ' . rex_escape($options['css_class'])
: '';

// Text-Variablen aus Fragment abrufen (von FriendsOfRedaxo\ConsentManager\InlineConsent::getButtonText())
$inline_title_fallback = $this->getVar('inline_title_fallback', 'Externes Medium');
Expand Down Expand Up @@ -55,7 +62,7 @@ class="consent-inline-thumbnail"
}
?>

<div class="consent-inline-container" data-consent-id="<?= rex_escape($consentId) ?>"
<div class="consent-inline-container<?= $extraClass ?>" data-consent-id="<?= rex_escape($consentId) ?>"
data-service="<?= rex_escape($serviceKey) ?>">

<div class="consent-inline-placeholder">
Expand Down
Loading