feat: block closed core recruitment submissions#321
Merged
CSE-Shaco merged 1 commit intoGDGoCINHA:developfrom Mar 15, 2026
Merged
feat: block closed core recruitment submissions#321CSE-Shaco merged 1 commit intoGDGoCINHA:developfrom
CSE-Shaco merged 1 commit intoGDGoCINHA:developfrom
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Walkthrough모집 마감 시간 이후 신청을 방지하기 위해 새로운 예외 클래스와 검증 로직을 추가했습니다. 오류 코드, 커스텀 예외, 예외 핸들러, 그리고 서비스 검증 메서드를 통해 마감 기한 이후의 신청을 차단합니다. Changes
Sequence DiagramsequenceDiagram
actor Client
participant Service as RecruitCoreApplicationService
participant Validator as validateRecruitmentOpen()
participant ExceptionHandler as RecruitCoreControllerExceptionHandler
Client->>Service: checkEligibility() / prefill() / submit()
Service->>Validator: Validate recruitment deadline
alt Recruitment Open
Validator->>Service: ✓ Validation passed
Service->>Client: Process request normally
else Recruitment Closed
Validator->>Service: ✗ Current time > RECRUITMENT_DEADLINE
Service->>ExceptionHandler: Throw RecruitCoreClosedException
ExceptionHandler->>ExceptionHandler: Log exception
ExceptionHandler->>Client: Return 403 FORBIDDEN<br/>with error message
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 연관된 이슈
✨ 작업 내용
💬 리뷰 요구사항(선택)
Summary by CodeRabbit
릴리스 노트