Skip to content

Added the option to set fsname manually - #28

Open
lowBudgetHypothermia wants to merge 4 commits into
GSI-HPC:masterfrom
lowBudgetHypothermia:fsname_flag
Open

Added the option to set fsname manually#28
lowBudgetHypothermia wants to merge 4 commits into
GSI-HPC:masterfrom
lowBudgetHypothermia:fsname_flag

Conversation

@lowBudgetHypothermia

Copy link
Copy Markdown
Collaborator

This was done to allow the copytool to archive to the same fs (TSM) from different lustre instances.

This was done to allow the copytool to archive to the same fs (TSM)
from different lustre instances.
Comment thread src/lhsmtool_tsm.c
"\t\t""hostname of tsm server\n"
"\t-c, --conf <file>\n"
"\t\t""option conf file\n"
"\t-f, --fsname\n"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the argument? (like with the --conf above?

Suggested change
"\t-f, --fsname\n"
"\t-f, --fsname </override_fs_name>\n"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not this one? Just being curious?

Comment thread src/lhsmtool_tsm.c Outdated
Comment thread src/lhsmtool_tsm.c Outdated
@lowBudgetHypothermia

Copy link
Copy Markdown
Collaborator Author

The changes you requested were implemented.

@ChristianTackeGSI ChristianTackeGSI left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider squashing all commits into one.

Comment thread src/lhsmtool_tsm.c
"\t-c, --conf <file>\n"
"\t\t""option conf file\n"
"\t-f, --fsname\n"
"\t\t""set fsname manually </override_fs_name>\n"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the </override_fs_name> to the wrong line?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants