enable return_linter - #725
Open
alanahjonas95 wants to merge 11 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dragosmg
reviewed
Jul 21, 2026
dragosmg
left a comment
dragosmg
left a comment
Collaborator
There was a problem hiding this comment.
Apologies for the repeated comment
Replace removed return() statements with explicit return() calls that include '# nolint: return_linter' comments. These early returns (returns in the middle of functions) are necessary for proper control flow and should not trigger the return_linter when enabled. Changes in R/col_plan.R: - Restore return(NULL) with nolint in check_span_structure_dots() - Restore return(rlang::quo(!!x)) with nolint in nested conditionals - Restore return(rlang::eval_tidy(x)) with nolint for quo calls - Restore return(as_length_one_quo.character(x)) with nolint - Add nolint to return(TRUE) in is_valid_tidyselect_call() - Add nolint to return(TRUE) in is_valid_quo_call() - Restore return() calls in check_col_plan_dots() with nolint comments Changes in R/tfrmt.R: - Add nolint to return(invisible(NULL)) in check_tfrmt() - Add nolint to return(quote(expr = )) in tfrmt_find_args() - Add nolint to return(arg_call) for identical checks - Add nolint to return(as_vars(...)) in nested conditionals - Add nolint to return(as_length_one_quo(...)) for quo args - Add nolint to return(arg_call_results\) for normal args - Add nolint to return(arg_val) at end of argument processing Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
🦺 Coverage summary🟢 Merging PR #725 ( ♻️ Comment updated with the latest results. Created on 2026-08-25 with covr2gh v0.0.0.9041. |
Collaborator
Author
|
@dragosmg ive put back the returns and added #nolint for the early returns in tfrmt.R and col_plan.R |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #726