-
Notifications
You must be signed in to change notification settings - Fork 121
Improve the performance of accessing ThreadedBlockData. #1417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
copi143
wants to merge
41
commits into
GTNewHorizons:master
Choose a base branch
from
copi143:cache-threadlocal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
49c97b5
Improve the performance of accessing ThreadedBlockData.
copi143 f5b8d4b
fix bugs
copi143 3739a8d
fix style
copi143 b79ab38
tidy
copi143 8463337
Merge remote-tracking branch 'upstream/master' into cache-threadlocal
copi143 ec789e4
refactor (no logic changes)
copi143 a689f24
refactor (no logic changes)
copi143 f297c3b
Also optimize for multiple indirect accesses to ThreadLocal.
copi143 87ede08
format
copi143 0ebc23c
don't printStackTrace
copi143 a69b93c
fix duplicate cache entries
copi143 258244f
Use a simple whitelist so that it only override methods that won't be…
copi143 c63ebc3
Overloaded methods in the base class also need to be inherited.
copi143 0bd4c91
can we overload setBlockBoundsBasedOnState?
copi143 a14f909
only init CeleritasBlockTransform once
copi143 0694915
comments
copi143 8d8d1fe
Cache non-parameter local variables as well.
copi143 df26395
Fix: used the wrong variable.
copi143 45b9207
Merge remote-tracking branch 'upstream/master' into cache-threadlocal
copi143 c1b751d
fixes in MixinBlock
Alexdoru d39c38f
Move mappings and methodCanOverload into the constructor, use Immutab…
copi143 f68d995
comment
copi143 233d0d6
Merge remote-tracking branch 'origin/cache-threadlocal' into cache-th…
copi143 0ece4de
Merge remote-tracking branch 'upstream/master' into cache-threadlocal
copi143 55787dc
Add method names to ClassConstantPoolParser
copi143 24c982c
Skip the analysis of irrelevant methods.
copi143 8267e82
set changed correctly
copi143 892343c
I hate style checks
copi143 39f296f
rearrange class + make some fields non-static (no code change)
Alexdoru 7d36097
extract method trackBlockShadowingFields
Alexdoru 63960f6
rearrange
Alexdoru 2bee26e
Merge branch 'master' into cache-threadlocal
Alexdoru 8b60e8d
Remove setBlockBoundsBasedOnState overload
copi143 59c553c
Merge remote-tracking branch 'upstream/master' into cache-threadlocal
copi143 8aa3f28
Place the cache for `this` after calling the base class constructor.
copi143 892fd61
Merge remote-tracking branch 'upstream/master' into cache-threadlocal
copi143 391711d
Merge remote-tracking branch 'upstream/master' into cache-threadlocal
copi143 8f4281e
Merge remote-tracking branch 'upstream/master' into cache-threadlocal
copi143 033bca0
fix
copi143 29daf16
apply main-branch's reorganization
copi143 97e311f
Merge remote-tracking branch 'upstream/master' into cache-threadlocal
copi143 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,7 +41,7 @@ public byte[] transform(String name, String transformedName, byte[] basicClass) | |
| cr.accept(cn, 0); | ||
| final boolean changed = inner.transformClassNode(transformedName, cn); | ||
| if (changed) { | ||
| final ClassWriter cw = new ClassWriter(ClassWriter.COMPUTE_MAXS); | ||
| final ClassWriter cw = new ClassWriter(ClassWriter.COMPUTE_FRAMES | ClassWriter.COMPUTE_MAXS); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that's gonna need a safe class writer to not blow up |
||
| cn.accept(cw); | ||
| final byte[] bytes = cw.toByteArray(); | ||
| AngelicaClassDump.dumpClass(transformedName, basicClass, bytes, this); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.