Conversation
Merging this PR will not alter performance
|
|
Test failures here are due to maxk not matching. |
|
Let's go ahead with this PR for now. I still want to look into maxk more, but this PR leaves the code in a pretty good working state. |
|
@ismael-mendoza this is ready for review! |
|
thanks! I can take a look today |
Co-authored-by: Ismael Mendoza <11745764+ismael-mendoza@users.noreply.github.com>
|
Let's see if removing this unused code works OK. I think it might and I do not recall why or what I was trying to do before. |
|
OK @ismael-mendoza! Thank you for the very helpful code review! This is ready for another look. |
Co-authored-by: Ismael Mendoza <11745764+ismael-mendoza@users.noreply.github.com>
|
@ismael-mendoza I recalled the general reason for the two classes here and added some notes on it. |
This PR gets stepk for interpolated images to match galsim exactly. 🎉
xref: #189