Added fortune command#24
Open
calebrwalk5 wants to merge 6 commits intoGandelXIV:mainfrom
calebrwalk5:main
Open
Added fortune command#24calebrwalk5 wants to merge 6 commits intoGandelXIV:mainfrom calebrwalk5:main
calebrwalk5 wants to merge 6 commits intoGandelXIV:mainfrom
calebrwalk5:main
Conversation
GandelXIV
reviewed
Jun 9, 2021
kernel/advanced_cmds/fortune.h
Outdated
|
|
||
| void ksh_fortune() { | ||
| const char fortunes[3] = {"Pohl's Law: Nothing is so good that somebody, somewhere, will not hate it.", "You either die a smart fella, or live long enough to become a fart smella", "Everyone asked you about your favorite dinosaur as a kid, now, nobody cares", "Even stock traders want to arrest hatred", "Generically, fiery liquors that produce madness in total abstainers.", "Our remedies oft in ourselves do lie,? Which we ascribe to heaven.", "One of the most conspicuous qualities of a man in security."}; | ||
| kprintc("\n"); |
Owner
There was a problem hiding this comment.
// You are passing a "string" on line 6, 8 and 9 as parameter, but kprintc() only accepts 'char'. If you want to print strings, use kprints(), defined in kernel/io.h.
Added the new $fortune command to ListOfOwnCmds
GandelXIV
requested changes
Jun 9, 2021
Owner
GandelXIV
left a comment
GandelXIV
left a comment
There was a problem hiding this comment.
Use display.kprintc() to print chars, and io.kprints to print string.
Also we dont have a random generation library, so no rand() function.
Had to do some tweaks to make it work.
| void ksh_fortune() { | ||
| const char fortunes[3] = {"Pohl's Law: Nothing is so good that somebody, somewhere, will not hate it.", "You either die a smart fella, or live long enough to become a fart smella", "Everyone asked you about your favorite dinosaur as a kid, now, nobody cares", "Even stock traders want to arrest hatred", "Generically, fiery liquors that produce madness in total abstainers.", "Our remedies oft in ourselves do lie,? Which we ascribe to heaven.", "One of the most conspicuous qualities of a man in security."}; | ||
| kprintc("\n"); | ||
| int RandIndex = rand() % sizeof(fortunes); |
Owner
There was a problem hiding this comment.
// We write all libraries from scratch, so no rand() function is available. You will need to write a rand.c and rand.h file in lib/.
GandelXIV
reviewed
Jun 14, 2021
Owner
GandelXIV
left a comment
GandelXIV
left a comment
There was a problem hiding this comment.
@calebrwalk Should i close this pull request?
| const char fortunes[3] = {"Pohl's Law: Nothing is so good that somebody, somewhere, will not hate it.", "You either die a smart fella, or live long enough to become a fart smella", "Everyone asked you about your favorite dinosaur as a kid, now, nobody cares", "Even stock traders want to arrest hatred", "Generically, fiery liquors that produce madness in total abstainers.", "Our remedies oft in ourselves do lie,? Which we ascribe to heaven.", "One of the most conspicuous qualities of a man in security."}; | ||
| kprintc('\n'); | ||
| int RandIndex = rand() % sizeof(fortunes); | ||
| kprints(arrayNum[RandIndex]); |
Owner
There was a problem hiding this comment.
// What variable is arrayNum? You have not declared it in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fortune command is a fortune cookie, it picks random silly quotes