-
Notifications
You must be signed in to change notification settings - Fork 245
Figure.histogram: Split parameter bar_width into bar_width and bar_offset #4316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5375cdc
Split bar_width into bar_width and bar_offset
yvonnefroehlich ec0e8a4
Update advanced tutorial
yvonnefroehlich ad19b4b
Add tests
yvonnefroehlich 6c14592
Add error when bar_offset is given without bar_width
yvonnefroehlich f6c8f0f
Add minus sign back
yvonnefroehlich a5b70f7
Merge branch 'main' into split-histogram-bar_width
yvonnefroehlich bc5482d
Merge branch 'main' into split-histogram-bar_width
yvonnefroehlich f9b9d90
Use quotation marks in error message
yvonnefroehlich 2e4c0e3
Merge branch 'main' into split-histogram-bar_width
yvonnefroehlich a52e00a
Add image comparison
yvonnefroehlich 6efb9e4
Add test_histogram_barwidth_baroffset.png into DVC
da861bf
Remove test
yvonnefroehlich 6910ab3
Remove DVC file for test image PNG
yvonnefroehlich d7aa200
Merge branch 'main' into split-histogram-bar_width
yvonnefroehlich 888dd5c
Remove default test image name
yvonnefroehlich 03dd11e
Add test image name
yvonnefroehlich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.