Improve stability of test_which_nonascii_path#4663
Merged
Merged
Conversation
seisman
added
maintenance
weiji14
changed the title
weiji14
approved these changes
Jun 4, 2026
seisman
removed
the
final review call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test_which_nonascii_pathis intended to verify downloading files to a path containing non-ASCII characters. However, it has been failing intermittently on Linux CI (https://github.com/GenericMappingTools/pygmt/actions/runs/26930086047/job/79447894394) due to a long-standing network connectivity issue (or possibly a GMT-related issue) on GitHub Actions runners.This PR makes the test more robust by skipping it when the download fails, preventing unrelated CI failures while still testing the intended functionality when the download succeeds.