Skip to content

[BREAKING][MISC] Set default constraint solver tolerance based on floating-point precision. #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duburcqa merged 2 commits into from
Apr 16, 2026
Merged

[BREAKING][MISC] Set default constraint solver tolerance based on floating-point precision. #2713

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67946aa
Set default constraint solver tolerance based on floating-point preci…
duburcqa Apr 14, 2026
fbaa8a2
Update tolerance docstring to reflect precision-dependent default.
duburcqa Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions genesis/engine/solvers/rigid/rigid_solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,10 @@ def build(self):
self.n_fixed_verts_ = max(1, self.n_fixed_verts)
self.n_candidate_equalities_ = max(1, self.n_equalities + self._options.max_dynamic_constraints)

# Resolve precision-dependent tolerance default
if self._options.tolerance is None:
self._options.tolerance = 1e-5 if gs.qd_float == qd.f32 else 1e-8
Comment thread
duburcqa marked this conversation as resolved.
Comment thread
duburcqa marked this conversation as resolved.

super().build()

self._init_mass_mat()
Expand Down
2 changes: 1 addition & 1 deletion genesis/options/solvers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ class RigidOptions(Options):
# constraint solver
constraint_solver: gs.constraint_solver = gs.constraint_solver.Newton
iterations: PositiveInt = 50
tolerance: PositiveFloat = 1e-6
tolerance: PositiveFloat | None = None
Comment thread
duburcqa marked this conversation as resolved.
ls_iterations: PositiveInt = 50
ls_tolerance: PositiveFloat = 1e-2
noslip_iterations: NonNegativeInt = 0
Expand Down
Loading