-
Notifications
You must be signed in to change notification settings - Fork 15
[AutoDiff] Autodiff 9: Heap-backed adstack: lift the Metal/Vulkan per-thread capacity cap #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
duburcqa
wants to merge
33
commits into
duburcqa/fix_adstack_perf
Choose a base branch
from
duburcqa/heap_backed_adstack
base: duburcqa/fix_adstack_perf
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 25 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
6ce0b9f
Move adstack primal/adjoint storage onto a per-dispatch heap buffer.
duburcqa 1942733
Extend heap-backed SPIR-V adstack to i32/u1 and reject other primitiv…
duburcqa 01b6fb4
[SPIRV] Fix empty-dispatch heap allocation, ctx_buffers_ use-after-fr…
duburcqa 4382ee1
[SPIRV] Remove dead AdStackHeapKind::function_scope path and align mi…
duburcqa f0f9281
[SPIRV] Eagerly emit ad_stack_heap_thread_base_* at alloca site to av…
duburcqa bfac9bb
[SPIRV] Skip adstack reject-unsupported-type test when device lacks s…
duburcqa d185383
[SPIRV] Widen adstack heap invoc_id*stride to u64 when Int64 is avail…
duburcqa 95707dc
fixup! Move adstack primal/adjoint storage onto a per-dispatch heap b…
duburcqa 77220a7
fixup! [SPIRV] Widen adstack heap invoc_id*stride to u64 when Int64 i…
duburcqa d1b7853
[SPIRV] Split cached-field comment: buffers are lazy, thread_base eager
duburcqa e767d2f
[LLVM] Move adstack primal/adjoint storage onto a per-runtime heap bu…
duburcqa 74cfbeb
Raise default_ad_stack_size from 32 to 256 on the heap-backed adstack.
duburcqa 945cf37
Expose default_ad_stack_size as a qd.init knob and document rationale.
duburcqa 3aa9c26
[LLVM] Size adstack heap by end-begin for range_for and zero-init on …
duburcqa 622a200
fixup! [LLVM] Size adstack heap by end-begin for range_for and zero-i…
duburcqa d9813a3
fixup! Raise default_ad_stack_size from 32 to 256 on the heap-backed …
duburcqa 17a5ea1
fixup! Expose default_ad_stack_size as a qd.init knob and document ra…
duburcqa 9d9e0c3
fixup! [LLVM] Size adstack heap by end-begin for range_for and zero-i…
duburcqa 324fed2
fixup! [LLVM] Size adstack heap by end-begin for range_for and zero-i…
duburcqa 4a49d88
fixup! [LLVM] Move adstack primal/adjoint storage onto a per-runtime …
duburcqa f016a05
[LLVM] Host-manage the adstack heap and size it tightly per task.
duburcqa 73ebd99
[AMDGPU] Free RuntimeContext per launch; restore tight adstack sizing.
duburcqa 4b2c22f
Fix stale preallocate_runtime_memory comment referencing removed adst…
duburcqa b9152b7
Address review comments: dead code + stale docs.
duburcqa 56187e7
[CUDA] Reject graph=True on kernels that use the reverse-mode autodif…
duburcqa 1039ce3
Address review comments: docs memory-cost formula + stale LLVM codege…
duburcqa 60e613d
Reflow adstack-related comments to fill 120-col lines (no content cha…
duburcqa e9b5e48
[SPIRV] Amortized doubling when growing the adstack heap buffers.
duburcqa 96fc260
Fix ensure_adstack_heap release-safety comment (AMDGPU does not hipFr…
duburcqa df52025
Scope cross-launch safety note to AMDGPU (CUDA has no device-side con…
duburcqa ecdf71c
Merge branch 'duburcqa/fix_adstack_perf' into duburcqa/heap_backed_ad…
hughperkins cda3a6a
[SPIRV/Metal] Cap advisory thread count to runtime-resolved ndrange i…
duburcqa 6cada5b
[SPIRV/Tests] Pin grad-over-ndarray-shape ndrange does not oversize p…
duburcqa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.