[Type] Tensor 9: Extended AugAssign coverage for layout-tagged…#529
Draft
hughperkins wants to merge 7 commits intohp/tensor-stork-8from
Draft
[Type] Tensor 9: Extended AugAssign coverage for layout-tagged…#529hughperkins wants to merge 7 commits intohp/tensor-stork-8from
hughperkins wants to merge 7 commits intohp/tensor-stork-8from
Conversation
… ndarrays Test-only PR pinning down the trickier subscript-rewrite paths that PR 8 covered only at the basic-AugAssign level: - All standard operators on the same canonical cell (+=, -=, *=, //=, %=) through one composite kernel. - Each AugAssign operator in its own kernel: +=, -=, *=, //=, %=, &=, |=, ^= - Read-and-write of the same canonical index in one statement (``x[i, j] = x[i, j] * 2 + x[i, j]``). - Neighbour dependence along a canonical axis (cumulative scan). - Mixed layout-tagged + untagged ndarrays in the same kernel — the rewrite must apply only to the tagged operand. - Three layout-tagged operands consumed by one composite expression. 11 tests, all pass.
hughperkins
commented
Apr 20, 2026
| @@ -0,0 +1,322 @@ | |||
| """Extended AugAssign coverage for layout-tagged ndarrays (PR 9). | |||
Collaborator
Author
There was a problem hiding this comment.
lets not mention pr numbers
hughperkins
commented
Apr 20, 2026
| @@ -0,0 +1,322 @@ | |||
| """Extended AugAssign coverage for layout-tagged ndarrays (PR 9). | |||
|
|
|||
| PR 8 already covered the basic ``x[i, j] += scalar`` case. This file | |||
Collaborator
Author
There was a problem hiding this comment.
lets not mention pr numbers
hughperkins
force-pushed
the
hp/tensor-stork-8
branch
from
93d71c5 to
fbc8f0c
Compare
hughperkins
force-pushed
the
hp/tensor-stork-9
branch
2 times, most recently
from
732d1ca to
af5e3be
Compare
hughperkins
force-pushed
the
hp/tensor-stork-8
branch
from
22d1ef4 to
93d71c5
Compare
The intro paragraph linked to `#fields` and `#ndarrays`, which never existed as headings on this page. The next paragraph already points readers at `tensor_types.md` for the underlying primitives, so just demote the broken links to plain code spans to satisfy markdown-link-check. Made-with: Cursor
Drops the 'flexible' prefix from filenames and identifiers introduced in this branch series so the user-visible names are simply 'tensor'. Also strips PR-N back-references that will be meaningless once these PRs land. Touches only files owned by this series (no changes to external/ or unrelated tests).
- Hoist a module-level pylint disable for import-outside-toplevel in python/quadrants/_tensor.py so the deliberate late imports (used to break circular dependencies with quadrants.lang and quadrants.types) do not trip pylint, without forcing black to balloon the import lines. - Reformat long raise statements in _tensor.py per black. - Apply ruff I001 import-order fixes to python/quadrants/__init__.py and the three new tensor test files. Made-with: Cursor
…r-stork-9 Made-with: Cursor # Conflicts: # docs/source/user_guide/tensor.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… ndarrays
Test-only PR pinning down the trickier subscript-rewrite paths that PR 8 covered only at the basic-AugAssign level:
x[i, j] = x[i, j] * 2 + x[i, j]).11 tests, all pass.
Issue: #
Brief Summary
copilot:summary
Walkthrough
copilot:walkthrough