[Type] Tensor 11: Higher-rank ndarray layout coverage#531
Draft
hughperkins wants to merge 4 commits intohp/tensor-stork-10from
Draft
[Type] Tensor 11: Higher-rank ndarray layout coverage#531hughperkins wants to merge 4 commits intohp/tensor-stork-10from
hughperkins wants to merge 4 commits intohp/tensor-stork-10from
Conversation
Test-only PR. PR 8's parametrized rank-3 test exercises every permutation on a single canonical cell. PR 11 widens that: - Rank 4: every permutation (24), full-grid value comparison. - Rank 5: 5 representative permutations (identity, full reverse, inner swap, cyclic shift, adjacent pair swaps), full-grid checks (32 cells). - Rank 6: 3 representative permutations, full-grid checks (64 cells). - Rank 4 + AugAssign + needs_grad on a non-trivial layout. - Rank 4 cross-check: tagged-with-layout vs direct-with-permuted-iteration produce the same physical buffer. Quadrants supports up to ``quadrants_max_num_indices=12``, so 6-D is well within the safe range; 5-D and 6-D ndranges become expensive at higher sizes so each axis is kept at 2. 34 tests, all pass.
hughperkins
force-pushed
the
hp/tensor-stork-10
branch
from
f8c9fbd to
fb5eb4f
Compare
hughperkins
force-pushed
the
hp/tensor-stork-11
branch
from
9a7e090 to
af10d02
Compare
hughperkins
force-pushed
the
hp/tensor-stork-10
branch
from
fb5eb4f to
f8c9fbd
Compare
hughperkins
force-pushed
the
hp/tensor-stork-11
branch
from
af10d02 to
9a7e090
Compare
Drops the 'flexible' prefix from filenames and identifiers introduced in this branch series so the user-visible names are simply 'tensor'. Also strips PR-N back-references that will be meaningless once these PRs land. Touches only files owned by this series (no changes to external/ or unrelated tests).
- Apply black/ruff fixes to _tensor.py and tests; sort imports. - Silence pylint C0415 on intentional late imports in _tensor.py (needed to break circular dependencies). - Drop broken #fields / #ndarrays anchor links in tensor.md; no such headings exist on the page. Made-with: Cursor
…or-stork-11 Made-with: Cursor # Conflicts: # docs/source/user_guide/tensor.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only PR. PR 8's parametrized rank-3 test exercises every permutation on a single canonical cell. PR 11 widens that:
Quadrants supports up to
quadrants_max_num_indices=12, so 6-D is well within the safe range; 5-D and 6-D ndranges become expensive at higher sizes so each axis is kept at 2.34 tests, all pass.
Issue: #
Brief Summary
copilot:summary
Walkthrough
copilot:walkthrough