fix(cloudstore): invalidate dashboard read model cache on mutation insert#253
fix(cloudstore): invalidate dashboard read model cache on mutation insert#253idrojone wants to merge 2 commits intoGentleman-Programming:mainfrom
Conversation
This ensures the dashboard reflects new memories arriving via autosync push without requiring a server restart.
Alan-TheGentleman
left a comment
There was a problem hiding this comment.
Thanks for the focused fix. The actual cache invalidation change is correct, but I am not going to merge this PR while it also changes Docker Compose defaults and .gitignore.
Please keep this PR scoped to #251: leave the cs.invalidateDashboardReadModel() call, add a focused regression test for InsertMutationBatch, and remove the unrelated .gitignore and docker-compose.cloud.yml changes. The Compose changes are especially risky because they replace zero-config local defaults with required env vars and change localhost-only bindings to 0.0.0.0. Once the PR is scoped down, I can review it on the actual bug fix.
|
Thanks for the review. You’re right about the scope.
|
🔗 Linked Issue
Closes #251
🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:docs— Documentation onlytype:refactor— Code refactoring (no behavior change)type:chore— Maintenance, dependencies, toolingtype:breaking-change— Breaking change📝 Summary
📂 Changes
internal/cloud/cloudstore/cloudstore.gointernal/cloud/cloudstore/project_controls_test.go🧪 Test Plan
go test ./...go test -tags e2e ./internal/server/...🤖 Automated Checks
Closes #N/Fixes #N/Resolves #Nstatus:approvedlabeltype:*labelgo test ./...passesgo test -tags e2e ./internal/server/...passes✅ Contributor Checklist
Closes #N)type:*label to this PRgo test ./...go test -tags e2e ./internal/server/...Co-Authored-Bytrailers in commits💬 Notes for Reviewers
Scoped to #251 only: cache invalidation fix + regression test. No Docker Compose or .gitignore changes.