fix: handle symlinks in WriteFileAtomic#307
Open
utafrali wants to merge 1 commit intoGentleman-Programming:mainfrom
Open
fix: handle symlinks in WriteFileAtomic#307utafrali wants to merge 1 commit intoGentleman-Programming:mainfrom
utafrali wants to merge 1 commit intoGentleman-Programming:mainfrom
Conversation
utafrali
force-pushed
the
fix/issue-306-error-in-the-sync-uninstall-commands-for
branch
from
65fcd71 to
c9984a8
Compare
|
I also use Stow to sync my dotfiles, and this error is a real headache. Thanks for the PR, and I hope it gets reviewed soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #306
PR Type
Summary
Was hitting errors when writing to symlinked config files, which breaks dotfile managers like stow and chezmoi. The issue was WriteFileAtomic was treating symlinks as regular files and potentially replacing them instead of updating the target.
Added symlink resolution so we write to the actual file and preserve the symlink.
Changes
Test Plan
Added TestWriteFileAtomic_PreservesSymlink which creates a symlink, writes through it, and verifies the target file is updated while the symlink stays intact. Existing tests pass.