fix(commands): replace legacy inline shell interpolation with $PWD for Claude Code v2.1.113+ by baltasarblanco · Pull Request #370 · Gentleman-Programming/gentle-ai

baltasarblanco · 2026-04-24T03:13:42Z

🔗 Linked Issue

Closes #365

🏷️ PR Type

What kind of change does this PR introduce?

type:bug — Bug fix (non-breaking change that fixes an issue)
type:feature — New feature (non-breaking change that adds functionality)
type:docs — Documentation only
type:refactor — Code refactoring (no functional changes)
type:chore — Build, CI, or tooling changes
type:breaking-change — Breaking change (fix or feature that changes existing behavior)

📝 Summary

After Claude Code v2.1.113+ migrated its runtime to a native binary, the command parser introduced stricter permission checks during initialization. This update rejects legacy inline shell interpolation syntax (!`echo -n "$(pwd)"` and !`echo -n "$(basename $(pwd))"`), causing all 5 SDD slash commands (/sdd-new, /sdd-init, /sdd-ff, /sdd-explore, /sdd-continue) to fail immediately with:
Error: Shell command permission check failed for pattern "!...": Unhandled node type: string

This PR replaces the problematic backtick interpolation with the native $PWD environment variable across all affected command templates. The fix was validated by the issue reporter and aligns with Claude Code's current variable resolution behavior. No Go logic, injection flows, or adapter interfaces were modified — only static command assets and their corresponding golden snapshots were updated.

📂 Changes

File / Area	What Changed
`internal/assets/claude/commands/sdd-{new,init,ff,explore,continue}.md`	Replaced legacy !`echo...` interpolation with `$PWD` in the `CONTEXT:` block
`testdata/golden/sdd-claude-cmd-sdd-{new,init,ff,explore,continue}.golden`	Updated snapshot files to match the new command templates

🧪 Test Plan

Unit Tests

go test ./internal/components/sdd/...

E2E Tests (Docker required)

cd e2e && ./docker-test.sh

Unit tests pass (go test ./...)
E2E tests pass (cd e2e && ./docker-test.sh)
Manually tested locally

🤖 Automated Checks

The following checks run automatically on this PR:

Check	Status	Description
Check Issue Reference	⏳	PR body must contain `Closes/Fixes/Resolves #N`
Check Issue Has `status:approved`	⏳	Linked issue must have been approved before work began
Check PR Has `type:*` Label	⏳	Exactly one `type:*` label must be applied
Unit Tests	⏳	`go test ./...` must pass
E2E Tests	⏳	`cd e2e && ./docker-test.sh` must pass

✅ Contributor Checklist

PR is linked to an issue with status:approved
I have added the appropriate type:* label to this PR
Unit tests pass (go test ./...)
E2E tests pass (cd e2e && ./docker-test.sh)
I have updated documentation if necessary
My commits follow Conventional Commits format
My commits do not include Co-Authored-By trailers

💬 Notes for Reviewers

This is a purely cosmetic/template fix. The change swaps deprecated shell backtick execution for native environment variable resolution ($PWD), which is fully supported by Claude Code's current runtime. The fix is backward-compatible, requires zero changes to Go code or injection logic, and restores immediate functionality for SDD slash commands on v2.1.113+. Golden snapshots were updated accordingly. Ready for review!

…r Claude Code v2.1.113+ - Fixes permission check failure on Claude Code native binary runtime - Updates source templates and golden snapshots accordingly - Closes Gentleman-Programming#365

baltasarblanco · 2026-04-24T03:19:22Z

Hi team! 🔹 This PR is ready for review.

Could a maintainer please:

✅ Approve the GitHub Actions workflows from the Actions tab (required for forked PRs)
🏷️ Add the type:bug label to this PR
🏷️ Confirm that issue bug(commands): SDD slash commands fail with "Unhandled node type: string" on Claude Code v2.1.113+ #365 has the status:approved label

Once approved, the CI checks will run automatically. All tests pass locally and golden snapshots are aligned. Thanks! 🙌

GerardoFC8 · 2026-04-28T14:29:34Z

Hey @baltasarblanco — thanks for picking this up, the diagnosis and the $PWD switch are spot on. 🙌

One thing to flag before merge: the same broken !`echo -n "$(pwd)"` / !`echo -n "$(basename $(pwd))"` pattern lives in 4 more command files that aren't in this PR's scope. The original issue only listed 5, but a grep across internal/assets/claude/commands/ shows the same pattern in:

internal/assets/claude/commands/sdd-onboard.md (lines 9–10)
internal/assets/claude/commands/sdd-verify.md (lines 9–10)
internal/assets/claude/commands/sdd-archive.md (lines 9–10)
internal/assets/claude/commands/sdd-apply.md (lines 11–12)

If those don't ship in this PR, /sdd-onboard, /sdd-verify, /sdd-archive and /sdd-apply will still fail on Claude Code v2.1.113+ after the merge.

Would it be easy to extend this PR to cover them too (plus their matching golden files under testdata/golden/sdd-claude-cmd-*.golden)? Happy to follow up with a complementary PR if you'd rather keep this one focused — just let me know your preference.

baltasarblanco · 2026-04-29T03:30:48Z

Thanks for catching that! Good point — it makes sense to ship the fix atomically for all Claude Code commands. I'll extend this PR to include those 4 additional files (sdd-onboard, sdd-verify, sdd-archive, sdd-apply) and update their golden snapshots as well.

Updating now... 🛠️

- Replaces legacy backtick interpolation with native \$PWD environment variable - Covers original 5 commands + sdd-onboard, sdd-verify, sdd-archive, sdd-apply - Updates all matching golden snapshots - Full asset audit confirms zero legacy patterns remain - Closes Gentleman-Programming#365

baltasarblanco · 2026-04-29T04:04:29Z

Hi @GerardoFC8, thanks for the catch! 🙌

I've extended this PR to include those 4 additional files (sdd-onboard, sdd-verify, sdd-archive, sdd-apply) and their corresponding golden snapshots.

Extra Mile:
To ensure we don't leave any stones unturned, I ran a full audit (grep -r) across the entire internal/assets/ directory. Confirmed that those 9 files were the only ones using the deprecated backtick syntax.

This PR now provides a complete fix for the v2.1.113+ compatibility issue across all SDD commands. All tests pass and golden snapshots are aligned. Ready for review! 🔹

- Covers sdd-onboard, sdd-verify, sdd-archive, and sdd-apply - Updates matching golden snapshots - Full audit confirms zero legacy patterns remain - Closes Gentleman-Programming#365

baltasarblanco · 2026-04-29T15:23:39Z

🔗 Linked Issue

Closes #365

🏷️ PR Type

What kind of change does this PR introduce?

type:bug — Bug fix (non-breaking change that fixes an issue)

📝 Summary

After Claude Code v2.1.113+ migrated its runtime to a native binary, the command parser introduced stricter permission checks during initialization. This update rejects legacy inline shell interpolation syntax (!`echo -n "$(pwd)"`), causing SDD slash commands to fail with Unhandled node type: string.

This PR replaces the problematic backtick interpolation with the native $PWD environment variable across all 9 affected command templates. The fix was validated by the issue reporter and aligns with Claude Code's current variable resolution behavior. No Go logic, injection flows, or adapter interfaces were modified — only static command assets and their corresponding golden snapshots were updated.

📂 Changes

File / Area	What Changed
`internal/assets/claude/commands/sdd-*.md`	Replaced legacy !`echo...` interpolation with `$PWD` in the `CONTEXT:` block
`testdata/golden/sdd-claude-cmd-sdd-*.golden`	Updated snapshot files to match the new command templates

🧪 Test Plan

Unit Tests

go test ./internal/components/sdd/...

Unit tests pass (go test ./...)
Manually tested locally

✅ Contributor Checklist

PR is linked to an issue with status:approved
I have added the appropriate type:bug label to this PR
Unit tests pass (go test ./...)
My commits follow Conventional Commits format

💬 Notes for Reviewers

This is a purely cosmetic/template fix. The change swaps deprecated shell backtick execution for native environment variable resolution (\$PWD), which is fully supported by Claude Code's current runtime. The fix is backward-compatible, requires zero changes to Go code or injection logic, and restores immediate functionality for SDD slash commands on v2.1.113+. Golden snapshots were updated accordingly.

Ready for review! 🔹

fix(commands): replace legacy inline shell interpolation with $PWD fo…

8b1cb7e

…r Claude Code v2.1.113+ - Fixes permission check failure on Claude Code native binary runtime - Updates source templates and golden snapshots accordingly - Closes Gentleman-Programming#365

baltasarblanco changed the title ~~fix(commands): replace legacy inline shell interpolation with $PWD fo…~~ fix(commands): replace legacy inline shell interpolation with $PWD for Claude Code v2.1.113+ Apr 24, 2026

fix(commands): extend \$PWD fix to remaining Claude Code SDD commands

6205d04

- Covers sdd-onboard, sdd-verify, sdd-archive, and sdd-apply - Updates matching golden snapshots - Full audit confirms zero legacy patterns remain - Closes Gentleman-Programming#365

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(commands): replace legacy inline shell interpolation with $PWD for Claude Code v2.1.113+#370

fix(commands): replace legacy inline shell interpolation with $PWD for Claude Code v2.1.113+#370
baltasarblanco wants to merge 3 commits intoGentleman-Programming:mainfrom
baltasarblanco:fix/365-sdd-commands-claude-fix

baltasarblanco commented Apr 24, 2026 •

edited

Loading

Uh oh!

baltasarblanco commented Apr 24, 2026

Uh oh!

GerardoFC8 commented Apr 28, 2026

Uh oh!

baltasarblanco commented Apr 29, 2026

Uh oh!

baltasarblanco commented Apr 29, 2026

Uh oh!

baltasarblanco commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

baltasarblanco commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked Issue

🏷️ PR Type

📝 Summary

📂 Changes

🧪 Test Plan

🤖 Automated Checks

✅ Contributor Checklist

💬 Notes for Reviewers

Uh oh!

baltasarblanco commented Apr 24, 2026

Uh oh!

GerardoFC8 commented Apr 28, 2026

Uh oh!

baltasarblanco commented Apr 29, 2026

Uh oh!

baltasarblanco commented Apr 29, 2026

Uh oh!

baltasarblanco commented Apr 29, 2026

🔗 Linked Issue

🏷️ PR Type

📝 Summary

📂 Changes

🧪 Test Plan

✅ Contributor Checklist

💬 Notes for Reviewers

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

baltasarblanco commented Apr 24, 2026 •

edited

Loading