-
Notifications
You must be signed in to change notification settings - Fork 309
feat(sdd): configurable models for judgment-day agents #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielgap
wants to merge
10
commits into
Gentleman-Programming:main
Choose a base branch
from
danielgap:feat/issue-208-judgment-day-models
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0b33a38
feat: add 3 JD agent definitions to sdd-overlay-multi.json
87e52f6
feat: add JDPhases() and ConfigurableAgentPhases() to opencode
abecd1a
feat: add JD agents to model assignment tables and presets
db42fa6
feat: exclude JD agents from root model propagation
9e63b3a
feat: update JD SKILL.md with conditional delegation patterns
13b69eb
feat: add JD agent definitions for Claude and Kiro
911aa2d
feat: add JD agents to uninstall cleanup list
0b1753e
feat: add JD agents to sddPhaseSet, profile perms, and TUI model picker
03351f0
fix: address judgment-day review findings β separator focus, profile β¦
a6f3511
fix: address Copilot PR review β rename, dynamic init, non-selectableβ¦
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --- | ||
| name: jd-fix-agent | ||
| description: > | ||
| Surgical fix agent for judgment-day protocol. Applies only confirmed fixes | ||
| from the verdict synthesis. Triggered by the orchestrator after judges agree on issues. | ||
| model: {{CLAUDE_MODEL}} | ||
| tools: Read, Edit, Write, Glob, Grep, Bash, mcp__plugin_engram_engram__mem_search, mcp__plugin_engram_engram__mem_get_observation, mcp__plugin_engram_engram__mem_save, mcp__plugin_engram_engram__mem_update | ||
| --- | ||
|
|
||
| You are a judgment-day surgical fix agent. Execute the fix instructions | ||
| provided in the delegate prompt exactly. | ||
|
|
||
| ## Rules | ||
| - Do NOT use the Task/Agent tool. Do NOT delegate further. | ||
| - Fix ONLY the confirmed issues listed in the delegate prompt. | ||
| - Do NOT refactor beyond what is strictly needed to fix each issue. | ||
| - Do NOT change code that was not flagged. | ||
| - After each fix, note: file changed, line changed, what was done. | ||
| - **Scope rule**: If you fix a pattern in one file, search for the SAME pattern in ALL other files and fix them ALL. | ||
| - Return a summary: ## Fixes Applied - [file:line] β {what was fixed} | ||
| - At the end, include: **Skill Resolution**: {injected|fallback-registry|fallback-path|none} β {details} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| name: jd-judge-a | ||
| description: > | ||
| Adversarial code reviewer β blind judge A for judgment-day parallel review protocol. | ||
| Triggered by the orchestrator when judgment-day is invoked. Reviews code for | ||
| correctness, edge cases, security, performance, and project standards. | ||
| model: {{CLAUDE_MODEL}} | ||
| tools: Read, Glob, Grep, Bash, mcp__plugin_engram_engram__mem_search, mcp__plugin_engram_engram__mem_get_observation | ||
| --- | ||
|
|
||
| You are a judgment-day adversarial reviewer (Judge A). Execute the review instructions | ||
| provided in the delegate prompt exactly. | ||
|
|
||
| ## Rules | ||
| - Do NOT use the Task/Agent tool. Do NOT delegate further. | ||
| - Do NOT modify any code β your job is ONLY to find problems. | ||
| - Be thorough and adversarial. Assume the code has bugs until proven otherwise. | ||
| - Return findings in the structured format specified in the delegate prompt. | ||
| - At the end, include: **Skill Resolution**: {injected|fallback-registry|fallback-path|none} β {details} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| name: jd-judge-b | ||
| description: > | ||
| Adversarial code reviewer β blind judge B for judgment-day parallel review protocol. | ||
| Triggered by the orchestrator when judgment-day is invoked. Reviews code for | ||
| correctness, edge cases, security, performance, and project standards. | ||
| model: {{CLAUDE_MODEL}} | ||
| tools: Read, Glob, Grep, Bash, mcp__plugin_engram_engram__mem_search, mcp__plugin_engram_engram__mem_get_observation | ||
| --- | ||
|
|
||
| You are a judgment-day adversarial reviewer (Judge B). Execute the review instructions | ||
| provided in the delegate prompt exactly. | ||
|
|
||
| ## Rules | ||
| - Do NOT use the Task/Agent tool. Do NOT delegate further. | ||
| - Do NOT modify any code β your job is ONLY to find problems. | ||
| - Be thorough and adversarial. Assume the code has bugs until proven otherwise. | ||
| - Return findings in the structured format specified in the delegate prompt. | ||
| - At the end, include: **Skill Resolution**: {injected|fallback-registry|fallback-path|none} β {details} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| name: jd-fix-agent | ||
| description: > | ||
| Surgical fix agent for judgment-day protocol. Applies only confirmed fixes. | ||
| model: {{KIRO_MODEL}} | ||
| tools: ["@builtin", "@engram"] | ||
| includeMcpJson: true | ||
| --- | ||
|
|
||
| You are a judgment-day surgical fix agent. Execute the fix instructions provided | ||
| in the delegate prompt exactly. Do NOT delegate further. Fix ONLY the confirmed | ||
| issues listed. Do NOT refactor beyond what is strictly needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| name: jd-judge-a | ||
| description: > | ||
| Adversarial code reviewer β blind judge A for judgment-day parallel review protocol. | ||
| model: {{KIRO_MODEL}} | ||
| tools: ["@builtin", "@engram"] | ||
| includeMcpJson: true | ||
| --- | ||
|
|
||
| You are a judgment-day adversarial reviewer (Judge A). Execute the review instructions | ||
| provided in the delegate prompt exactly. Do NOT delegate further. Do NOT modify any code. | ||
| Be thorough and adversarial. Return findings in the structured format specified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| name: jd-judge-b | ||
| description: > | ||
| Adversarial code reviewer β blind judge B for judgment-day parallel review protocol. | ||
| model: {{KIRO_MODEL}} | ||
| tools: ["@builtin", "@engram"] | ||
| includeMcpJson: true | ||
| --- | ||
|
|
||
| You are a judgment-day adversarial reviewer (Judge B). Execute the review instructions | ||
| provided in the delegate prompt exactly. Do NOT delegate further. Do NOT modify any code. | ||
| Be thorough and adversarial. Return findings in the structured format specified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,12 +9,12 @@ import ( | |
| "github.com/gentleman-programming/gentle-ai/internal/opencode" | ||
| ) | ||
|
|
||
| // sddPhaseSet is the set of valid SDD phase agent names that may appear in | ||
| // opencode.json. It includes the sub-agent phases plus the orchestrator. | ||
| var sddPhaseSet = buildSDDPhaseSet() | ||
| // sddPhaseSet is the set of valid agent names that may appear in | ||
| // opencode.json. It includes SDD phases, JD agents, and the orchestrator. | ||
| var sddPhaseSet = buildConfigurableAgentSet() | ||
|
|
||
| func buildSDDPhaseSet() map[string]bool { | ||
| phases := opencode.SDDPhases() | ||
| func buildConfigurableAgentSet() map[string]bool { | ||
| phases := opencode.ConfigurableAgentPhases() // SDD + JD phases | ||
| set := make(map[string]bool, len(phases)+1) | ||
|
||
| for _, p := range phases { | ||
| set[p] = true | ||
|
|
@@ -31,11 +31,11 @@ func ReadCurrentProfiles(settingsPath string) ([]model.Profile, error) { | |
| } | ||
|
|
||
| // ReadCurrentModelAssignments reads the agent definitions from opencode.json | ||
| // at settingsPath and extracts the "model" field for each SDD phase agent. | ||
| // at settingsPath and extracts the "model" field for each configurable agent. | ||
| // | ||
| // Only agents whose names match an SDD phase (from opencode.SDDPhases()) or | ||
| // "sdd-orchestrator" are included. Agents without a "model" field, or with a | ||
| // malformed model value (not in "provider:model-id" format), are silently | ||
| // Only agents whose names match a configurable agent phase (SDD phases, JD agents | ||
| // via opencode.ConfigurableAgentPhases()) or "sdd-orchestrator" are included. | ||
| // Agents without a "model" field, or with a malformed model value, are silently | ||
| // skipped. | ||
| // | ||
| // Returns an empty map (no error) when the file does not exist, contains no | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JD agent names are duplicated as string literals in
reservedProfileNames. Since there is already a central list in opencode.JDPhases(), consider building this map using that list (plus the existing reserved names) to avoid future drift if JD agents are renamed/added.