[pull] master from ninja-build:master#109
Merged
Merged
Conversation
This should fix part of the compiler warnings described in issue #2615. The first warning is likely a GCC bug as the complete statement can never trigger the condition the compiler complains about, i.e.: ``` char buf[kMaxRecordSize + 1]; ... if (size > kMaxRecordSize || fread(buf, size, 1, file) < 1) { ... } ```
Also add -DCMAKE_COMPILE_WARNING_AS_ERROR=1 to Cmake release builds. Note that enabling them for debug builds triggers far too many warnings, in particular in re2-generated code (e.g. lexer.cc) or in third-party one (e.g. src/third_party/emhash/hash_table8.hpp). See issue #2615 for context. + Fix a number of compiler warnings, most of them related to losing integer precision (e.g. from size_t to int), or ignoring function results.
Remove 1.13 warnings and enable -Werror for release builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.2)
Can you help keep this open source service alive? 💖 Please sponsor : )