[pull] next from storybookjs:next#830
Merged
Merged
Conversation
When a bundler splits a CSF4 story module (no `export default meta`)
into a separate chunk, the namespace object passed to `<Meta of={...} />`
differs by object identity from the one Storybook registered. The
existing default-export fallback in `DocsContext.resolveModuleExport`
cannot handle this case because CSF4 modules have no `default` key.
Fall back to identifying the CSF file via any of its story exports.
Reject the lookup when story exports span multiple CSF files. Guard
against individual CSF4 Story objects so `<Canvas of={Stories.Primary} />`
keeps resolving to a story.
Fixes #34159
Fixes #34373
Distilled from recurring failure modes in agent-authored PRs: comments as investigation transcript, bending production to the test harness, unproven environment assumptions, over-engineered defensive tests, convention drift in generated files, and speculative generality. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Use ">= 4.9.x" (matching @storybook/react-webpack5 and the react renderer) instead of ">=4.9.x", and refresh yarn.lock. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collapse the Map build / Array.from / filter / map / Object.fromEntries pipeline into one loop that builds the result object directly, preserving last-wins rule deduplication. Drops the type cast as well. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
the looser `unknown[]` type doesn't work well with Generic + conditional type logic
…meta-split-chunk Addon-Docs: Resolve CSF4 module exports without a default export
CSF-Next: Add tags type support for
…rules-34647 A11y-Addon: Preserve disabled a11y rules with runOnly
Add an optional TypeScript peer to react-vite
…ore-timeout Core: Categorize UniversalStore follower timeout error
Core: Add runtime instance registry
…5.0-alpha.1 Release: Prerelease 10.5.0-alpha.2
…ts-md Docs: Add Code Authoring Principles for agents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )