[pull] next from storybookjs:next#878
Merged
Merged
Conversation
…rameter
The decorator's parameter->globals sync effect was emitting UPDATE_GLOBALS
with an empty config on every story that didn't declare 'parameters.pseudo'.
On initial load, this overwrote pseudo state globals supplied via URL or
toolbar (e.g. ?globals=pseudo.focusVisible:!true) with {}, dropping the
user's selection before it could be applied.
Skip the sync when the parameter has no pseudo states to push, so URL and
toolbar globals survive on stories that don't set the parameter themselves.
Fixes #32221
PseudoStates: Preserve URL globals on story change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )