[pull] next from storybookjs:next#888
Merged
Merged
Conversation
Avoid re-collapsing chrome and re-applying filters on in-review navigation.
Centralize unseen/visited/notified tracking, auto-accept on review routes, and notification slot deduplication in sessionStorage.
Track deferred review payloads internally and expose a notificationKey so notification effects re-run when displayed or pending reviews change.
Defer superseding review updates, sync notification state to the store, and clear arrival notifications on dismiss or pending accept.
Surface new reviews via the manager notification API instead of auto-navigating away from the user's current canvas.
Replace auto-navigation on review push with the notification layer.
…pdates Use the shared review store for the widget title and navigate via the canonical review summary entry helper.
Reset the review store between stories, stabilize createdAt fixtures, align assertions with Update navigation and router-based widget opens, and wait for notification effects before asserting on mocks.
The story mocked addNotification without rendering NotificationList, so the canvas showed no notification despite the play test passing. Use a harness that mirrors sidebar notification state and assert the visible headline.
Thumbnail previews on the review summary emitted STORY_SPECIFIED, which the manager treated as canvas navigation and replaced the URL. Treat review routes as non-canvas and keep review viewMode in the main layout so the summary stays mounted.
…t-config VSCode: Do not reference removed config files
…checklist UI: Hide onboarding menu with feature flag
…ed-hovered A11y: Surface required args and keyboard-reachable Setup controls in ArgsTable
The merge from next dropped hasActiveFilters from story-index-filters but left the import in stories.ts, breaking core:compile:production.
…pdate. Record the notified slot when a review is accepted and read pending state from the store at click time so layout-effect sync cannot re-post the sidebar toast.
Deferred superseding pushes on review routes already surface the Update banner, so suppress the sidebar notification and sync pending state to the store immediately.
Review: Notify on review arrival instead of auto-navigating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )