[pull] master from tensorflow:master#1682
Merged
Merged
Conversation
PiperOrigin-RevId: 892693575
PiperOrigin-RevId: 892695144
It is not needed. PiperOrigin-RevId: 892731368
It looks like it was run by mistake on all platforms, although it should serve as regression test for a PTXAS bug (so relevant to GPU backend only). By now, the bug is long fixed and we don't need this test anymore. PiperOrigin-RevId: 892746106
GpuTargetConfig has a constructor that takes a `StreamExecutor` and determines the config from the current GPU. In this process an instance of `DeviceDescription` is being stored in the `GpuTargetConfig`. This instance contains fields that are unique to the current GPU - like the PCI Bus ID and some unique NVLINK UUIDs. That makes the GpuTargetConfig between 2 GPUs of the same model not identical anymore which is a problem when used as a cache key like in a lot of our systems. This change removes the device specific fields from `DeviceDescription` when constructing a `GpuTargetConfig`. We shouldn't depend on those fields when targeting a GPU anyway. In fact I have checked, none of these fields are being used in the XLA compilation process. The only usages are in Tensorflow (no `GpuTargetConfig`, just bare `DeviceDescription` which is fine), and in `CudaExecutor` which is runtime and also okay. PiperOrigin-RevId: 892760770
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )