[pull] master from tensorflow:master#1989
Merged
Merged
Conversation
…_size() validation. PiperOrigin-RevId: 941098195
PiperOrigin-RevId: 941142259
Updates LLVM usage to match [c7e2809a631a](llvm/llvm-project@c7e2809a631a) PiperOrigin-RevId: 941147999
--- When exporting StableHLOComposite attributes, flexbuffers::Builder was being called with the attribute name as a key for every vector element. In flexbuffers, passing a key to a Vector element pushes both the key and the value to the stack, causing the vector to be parsed with twice its intended length (with the key interleaved). This change removes the key from the vector element calls, and only uses the key when starting the parent vector, which matches the flexbuffers::Builder API expectation for Vectors. - Also fixed a typo where `isa<StringAttr>(attr)` was checking the Array attribute instead of the element. - Updated test to pass actual vector values for serialization PiperOrigin-RevId: 941177131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )