Skip to content

Reconnect logic improvements, based on the connection state and/or backend API errors - #1476

Merged
aleksandar-apostolov merged 14 commits into
developfrom
reconnect-improvements
Jul 28, 2025
Merged

Reconnect logic improvements, based on the connection state and/or backend API errors#1476
aleksandar-apostolov merged 14 commits into
developfrom
reconnect-improvements

Conversation

@aleksandar-apostolov

@aleksandar-apostolov aleksandar-apostolov commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

🎯 Goal

Improve reconnect logic as per specs.

🛠 Implementation details

SfuSocket

  • HealthCheck and liveness set to 5s and 15s

PeerConnection

  • ICE connection failure will trigger a restartIce in 2-3 seconds if connection does not recover itsef.
  • Connection change to FAILED will trigger a rejoin()

SignalingApi

  • new error code (PARTICIPANT_SIGNAL_LOST) will trigger a fast reconnect

@aleksandar-apostolov
aleksandar-apostolov requested a review from a team as a code owner July 9, 2025 14:47
@aleksandar-apostolov aleksandar-apostolov added the pr:improvement Enhances an existing feature or code label Jul 9, 2025
@github-actions

github-actions Bot commented Jul 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.41 MB 11.43 MB 0.02 MB 🟢
stream-video-android-ui-xml 5.70 MB 5.68 MB -0.02 MB 🚀
stream-video-android-ui-compose 5.88 MB 5.88 MB 0.00 MB 🟢

@aleksandar-apostolov aleksandar-apostolov changed the title Reconnect improvements Improve and align reconnect logic Jul 10, 2025
rahul-lohra
rahul-lohra approved these changes Jul 28, 2025
View reviewed changes

@rahul-lohra rahul-lohra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

@aleksandar-apostolov aleksandar-apostolov changed the title Improve and align reconnect logic Improve the reconnect logic based on the peer connection state and/or errors that are received in the the API response Jul 28, 2025
@aleksandar-apostolov aleksandar-apostolov changed the title Improve the reconnect logic based on the peer connection state and/or errors that are received in the the API response Reconnect logic improvements, based on the connection state and/or backend API errors Jul 28, 2025
@sonarqubecloud

sonarqubecloud Bot commented Jul 28, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
7.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@aleksandar-apostolov
aleksandar-apostolov merged commit 5ad021c into develop Jul 28, 2025
10 of 11 checks passed
@aleksandar-apostolov
aleksandar-apostolov deleted the reconnect-improvements branch July 28, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahul-lohra rahul-lohra rahul-lohra approved these changes

Assignees

No one assigned

Labels

pr:improvement Enhances an existing feature or code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aleksandar-apostolov @rahul-lohra