Handle “accept call” action in onNewIntent and update intent reference - #1477
Closed
rahul-lohra wants to merge 4 commits into
Closed
Handle “accept call” action in onNewIntent and update intent reference#1477rahul-lohra wants to merge 4 commits into
rahul-lohra wants to merge 4 commits into
Conversation
Contributor
SDK Size Comparison 📏
|
|
| when (intent.action) { | ||
| NotificationHandler.ACTION_ACCEPT_CALL -> { | ||
| // Exit case | ||
| // TODO Later |
Contributor
There was a problem hiding this comment.
Exit the current call and join the new one. If they are different. If we are accepting the same call, do nothing.
Contributor
There was a problem hiding this comment.
This should also be customisable behaviour so an open function as hook should be added.
rahul-lohra
marked this pull request as draft
July 28, 2025 05:28
Contributor
Author
|
Closed. It is included as part of #1478 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR ensures correct intent handling for call actions by:
setIntent(intent)insideonNewIntent()so that lifecycle methods likeonResume()always receive the latest intent.onNewIntent()to allow faster and more reliable call acceptance when the activity is already running.🛠 Implementation details
Describe the implementation
🎨 UI Changes
Add relevant screenshots
Screen.Recording.2025-07-18.at.12.14.16.PM.mov
Screen.Recording.2025-07-18.at.12.17.22.PM.mov