Improve the behaviour when rejecting a call while already in an active call

[rahul-lohra]

🎯 Goal

Improve call rejection from Notification Button

🛠 Implementation details

"The UI observes Call.state.rejectedBy. If the value indicates the current user, the code will attempt to close the activity, provided there is no active call."

/**
           * Call can be rejected by [RejectCallBroadcastReceiver] so the activity
           * needs to observe [Call.state.rejectedBy]
           */
          val rejectedBy by call.state.rejectedBy.collectAsStateWithLifecycle()
          LaunchedEffect(rejectedBy) {
              val currentUserId = StreamVideo.instanceOrNull()?.userId
              if (rejectedBy.contains(currentUserId)) {
                  // check if there is no ongoing call then safely finish it else do nothing
                  val noActiveCall = (StreamVideo.instanceOrNull()?.state?.activeCall?.value == null)
                  if (noActiveCall) {
                      onEnded(call)
                      val configuration = configurationMap[call.id]
                      if (configuration?.closeScreenOnCallEnded == true) {
                          safeFinish()
                      } else {
                          logger.d { "Don't close activity as some other call is active" }
                      }
                  }
              }
          }

We are updating rejectedBy from the RejectCallBroadcastReceiver

internal class RejectCallBroadcastReceiver : GenericCallActionBroadcastReceiver() {


    override suspend fun onReceive(call: Call, context: Context, intent: Intent) {
        when (val rejectResult = call.reject(RejectReason.Decline)) {
            is Result.Success -> {
                val userId = StreamVideo.instanceOrNull()?.userId
                userId?.let {
                    val set = mutableSetOf(it)
                    call.state.updateRejectedBy(set)
                }
                logger.d { "[onReceive] rejectCall, Success: $rejectResult" }
            }            
        ...
    }
}

[github-actions]

SDK Size Comparison 📏

SDK	Before	After	Difference	Status
stream-video-android-core	11.43 MB	11.43 MB	0.00 MB	🟢
stream-video-android-ui-xml	5.70 MB	5.70 MB	0.00 MB	🟢
stream-video-android-ui-compose	5.88 MB	5.89 MB	0.02 MB	🟢

[sonarqubecloud]

Quality Gate failed

Failed conditions
4.4% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE