[Telecom-1] Stabilize Telecom and service dependency lifecycle

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/ClientState.kt

@@ -86,7 +86,7 @@
     public val activeCall: StateFlow<Call?> = _activeCall
 
     public val callConfigRegistry = (client as StreamVideoClient).callServiceConfigRegistry
-    private val serviceLauncher = ServiceLauncher(client.context)
+    internal val serviceLauncher = ServiceLauncher(streamVideoClient)
 
     internal val clientEventReporter = (client as StreamVideoClient).analytics.clientEventReporter
 
@@ -171,7 +171,7 @@
     /**
      * Transition incoming/outgoing call to active on the same service
      */
     fun setActiveCall(call: Call) {
         this._activeCall.value = call
         val serviceTransitionDelayMs = 500L
         val ringingState = call.state.ringingState.value
@@ -196,7 +196,7 @@
                 val serviceClass = callServiceConfig.serviceClass
                 val isServiceRunning = ServiceIntentBuilder()
                     .isServiceRunning(this.client.context, serviceClass)
                 if (callServiceConfig.runCallServiceInForeground) {
                     if (!isServiceRunning) {
                         logger.e { "Outgoing call service should already be running" }
                     }
@@ -293,13 +293,11 @@
             CallService.TRIGGER_ONGOING_CALL -> serviceLauncher.showOnGoingCall(
                 call,
                 trigger,
-                streamVideoClient,
             )
 
             CallService.TRIGGER_OUTGOING_CALL -> serviceLauncher.showOutgoingCall(
                 call,
                 trigger,
-                streamVideoClient,
             )
 
             else -> {}
@@ -312,10 +310,7 @@
     internal fun maybeStopForegroundService(call: Call) {
         val callConfig = streamVideoClient.callServiceConfigRegistry.get(call.type)
         if (callConfig.runCallServiceInForeground) {
-            val context = streamVideoClient.context
-
             logger.d { "Building stop intent for call_id: ${call.cid}" }
-            val serviceLauncher = ServiceLauncher(context)
             serviceLauncher.stopService(call)
         }
     }

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/ExternalCallRejectionHandler.kt

@@ -22,7 +22,6 @@ import android.os.Bundle
 import io.getstream.log.taggedLogger
 import io.getstream.result.Result
 import io.getstream.video.android.core.model.RejectReason
-import io.getstream.video.android.core.notifications.internal.service.ServiceLauncher
 import io.getstream.video.android.core.notifications.internal.telecom.TelecomCallController
 import io.getstream.video.android.model.StreamCallId
 
@@ -51,9 +50,7 @@ internal class ExternalCallRejectionHandler() {
         }
         logger.d { "[onRejectCall] source:$source, #ringing; callId: ${call.id}, action: ${intent.action}" }
 
-        val serviceLauncher = ServiceLauncher(context)
-        serviceLauncher.removeIncomingCall(
-            context,
+        StreamVideo.instance().state.serviceLauncher.removeIncomingCall(
             StreamCallId.fromCallCid(call.cid),
             StreamVideo.instance().state.callConfigRegistry.get(call.type),
         )

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/DefaultNotificationHandler.kt

@@ -48,7 +48,6 @@ import io.getstream.video.android.core.notifications.NotificationHandler.Compani
 import io.getstream.video.android.core.notifications.NotificationHandler.Companion.ACTION_NOTIFICATION
 import io.getstream.video.android.core.notifications.dispatchers.DefaultNotificationDispatcher
 import io.getstream.video.android.core.notifications.dispatchers.NotificationDispatcher
-import io.getstream.video.android.core.notifications.internal.service.ServiceLauncher
 import io.getstream.video.android.core.notifications.medianotifications.MediaNotificationConfig
 import io.getstream.video.android.core.notifications.medianotifications.MediaNotificationContent
 import io.getstream.video.android.core.notifications.medianotifications.MediaNotificationVisuals
@@ -88,7 +87,6 @@ public open class DefaultNotificationHandler(
     private val logger by taggedLogger("Call:NotificationHandler")
     val intentResolver =
         DefaultStreamIntentResolver(application, DefaultNotificationIntentBundleResolver())
-    private val serviceLauncher = ServiceLauncher(application)
 
     protected val notificationManager: NotificationManagerCompat by lazy {
         NotificationManagerCompat.from(application).also {
@@ -114,14 +112,12 @@ public open class DefaultNotificationHandler(
     ) {
         logger.d { "[onRingingCall] #ringing; callId: ${callId.id}" }
         val streamVideo = StreamVideo.instance()
-        serviceLauncher.showIncomingCall(
-            application,
+        streamVideo.state.serviceLauncher.showIncomingCall(
             callId,
             callDisplayName,
             streamVideo.state.callConfigRegistry.get(callId.type),
             isVideo = isVideoCall(callId, payload),
             payload = payload,
-            streamVideo,
             notification = getRingingCallNotification(
                 RingingState.Incoming(),
                 callId,

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/handlers/StreamDefaultNotificationHandler.kt

@@ -57,7 +57,6 @@
 import io.getstream.video.android.core.notifications.dispatchers.NotificationDispatcher
 import io.getstream.video.android.core.notifications.extractor.DefaultNotificationContentExtractor
 import io.getstream.video.android.core.notifications.internal.service.CallService.Companion.TRIGGER_INCOMING_CALL
-import io.getstream.video.android.core.notifications.internal.service.ServiceLauncher
 import io.getstream.video.android.core.notifications.style.StyleProvider
 import io.getstream.video.android.core.utils.BackgroundRestrictions
 import io.getstream.video.android.core.utils.isAppInForeground
@@ -149,7 +148,6 @@
     NotificationPermissionHandler by notificationPermissionHandler {
 
     private val logger by taggedLogger("Video:StreamNotificationHandler")
-    private val serviceLauncher = ServiceLauncher(application)
     private val styleProvider = StyleProvider(application)
     private val batteryRestrictions = BackgroundRestrictions(application)
 
@@ -177,14 +175,12 @@
             val canRunService =
                 streamVideo.callServiceConfigRegistry.get(callId.type).runCallServiceInForeground
             if (canRunService) {
-                serviceLauncher.showIncomingCall(
-                    application,
+                streamVideo.state.serviceLauncher.showIncomingCall(
                     callId,
                     callDisplayName,
                     streamVideo.state.callConfigRegistry.get(callId.type),
                     isVideo = isVideoCall(callId, payload),
                     payload = payload,
-                    streamVideo,
                     notification = getRingingCallNotification(
                         RingingState.Incoming(),
                         callId,
@@ -203,7 +199,7 @@
         payload: Map<String, Any?>,
     ) {
         logger.d { "[onLiveCall] callId: ${callId.id}, callDisplayName: $callDisplayName" }
         // TODO: Replace StreamCallId.hashCode with StreamCallId.getNotificationId(appropriateType)
         val notificationId = callId.hashCode()
         val liveCallPendingIntent =
             intentResolver.searchLiveCallPendingIntent(callId, notificationId, payload)
@@ -254,7 +250,7 @@
         payload: Map<String, Any?>,
     ) {
         logger.d { "[onNotification] callId: ${callId.id}, callDisplayName: $callDisplayName" }
         // TODO: Replace StreamCallId.hashCode with StreamCallId.getNotificationId(appropriateType)
         val notificationId = callId.hashCode()
         val intent = intentResolver.searchNotificationCallPendingIntent(
             callId,
@@ -574,7 +570,7 @@
     override fun getSettingUpCallNotification(trigger: String, callId: StreamCallId): Notification? {
         return when (trigger) {
             /**
              * TODO: This logic is duplicated with getIncomingCallNotificationInternal.
              * Update it soon
              */
 
@@ -747,7 +743,7 @@
         logger.d {
             "[getSimpleOngoingCallNotification] callId: ${callId.id}, callDisplayName: $callDisplayName, isOutgoingCall: $isOutgoingCall, remoteParticipantCount: $remoteParticipantCount"
         }
         // TODO: Replace StreamCallId.hashCode with StreamCallId.getNotificationId(appropriateType)
         val notificationId = callId.hashCode() // Notification ID
 
         // Intents
@@ -1183,7 +1179,7 @@
         },
     ): Notification {
         logger.d { "[getMinimalMediaStyleNotification] callId: ${callId.id}" }
         // TODO: Replace StreamCallId.hashCode with StreamCallId.getNotificationId(appropriateType)
         val notificationId = callId.hashCode() // Notification ID
         // Intents
         val onClickIntent = intentResolver.searchOngoingCallPendingIntent(

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/IncomingCallPresenter.kt

@@ -28,7 +28,7 @@
 import io.getstream.video.android.core.utils.safeCallWithResult
 import io.getstream.video.android.model.StreamCallId
 
-internal class IncomingCallPresenter(private val serviceIntentBuilder: ServiceIntentBuilder) {
+internal class IncomingCallPresenter(private val client: StreamVideo, private val serviceIntentBuilder: ServiceIntentBuilder) {
     private val logger by taggedLogger("IncomingCallPresenter")
 
     fun showIncomingCall(
@@ -103,7 +103,7 @@
         context: Context,
         notification: Notification?,
         callId: StreamCallId,
         error: Any?,
     ): ShowIncomingCallResult {
         if (!hasNotificationPermission(context) || notification == null) {
             logger.w {
@@ -114,9 +114,9 @@
             return ShowIncomingCallResult.ERROR
         }
 
-        StreamVideo.instanceOrNull()
-            ?.getStreamNotificationDispatcher()
-            ?.notify(
+        client
+            .getStreamNotificationDispatcher()
+            .notify(
                 callId,
                 callId.getNotificationId(NotificationType.Incoming),
                 notification,
@@ -131,7 +131,7 @@
 
     private fun hasNoActiveCall(): Boolean {
         val hasActiveCall =
-            StreamVideo.instanceOrNull()?.state?.activeCall?.value != null
+            client.state.activeCall?.value != null
         logger.d { "[showIncomingCall] hasActiveCall: $hasActiveCall" }
         return !hasActiveCall
     }

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/JetpackTelecomRepositoryProvider.kt

@@ -16,7 +16,6 @@
 
 package io.getstream.video.android.core.notifications.internal.service
 
-import android.content.Context
 import android.os.Build
 import androidx.annotation.RequiresApi
 import androidx.core.telecom.CallsManager
@@ -25,20 +24,30 @@ import io.getstream.video.android.core.notifications.internal.telecom.IncomingCa
 import io.getstream.video.android.core.notifications.internal.telecom.jetpack.JetpackTelecomRepository
 import io.getstream.video.android.model.StreamCallId
 
-internal class JetpackTelecomRepositoryProvider(private val context: Context) {
+internal class JetpackTelecomRepositoryProvider(private val streamVideo: StreamVideo) {
+
+    private val context = streamVideo.context.applicationContext ?: streamVideo.context
+    private val registrationLock = Any()
+    private lateinit var callsManager: CallsManager
 
     @RequiresApi(Build.VERSION_CODES.O)
     fun get(callId: StreamCallId): JetpackTelecomRepository {
-        val callsManager = CallsManager(context).apply {
-            registerAppWithTelecom(
-                capabilities = CallsManager.CAPABILITY_SUPPORTS_CALL_STREAMING and
-                    CallsManager.CAPABILITY_SUPPORTS_VIDEO_CALLING,
-            )
-        }
-
-        val streamVideo = StreamVideo.instance()
+        val callsManager = getOrRegisterCallsManager()
         val incomingCallTelecomAction =
             IncomingCallTelecomAction(streamVideo)
         return JetpackTelecomRepository(callsManager, callId, incomingCallTelecomAction)
     }
+
+    @RequiresApi(Build.VERSION_CODES.O)
+    private fun getOrRegisterCallsManager(): CallsManager = synchronized(registrationLock) {
+        if (!::callsManager.isInitialized) {
+            callsManager = CallsManager(context).also { manager ->
+                manager.registerAppWithTelecom(
+                    capabilities = CallsManager.CAPABILITY_SUPPORTS_CALL_STREAMING or
+                        CallsManager.CAPABILITY_SUPPORTS_VIDEO_CALLING,
+                )
+            }
+        }
+        callsManager
+    }
 }

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/ServiceLauncher.kt

@@ -34,14 +34,12 @@ package io.getstream.video.android.core.notifications.internal.service
 
 import android.annotation.SuppressLint
 import android.app.Notification
-import android.content.Context
 import android.os.Bundle
 import androidx.core.app.NotificationManagerCompat
 import androidx.core.content.ContextCompat
 import androidx.core.net.toUri
 import io.getstream.log.taggedLogger
 import io.getstream.video.android.core.Call
-import io.getstream.video.android.core.StreamVideo
 import io.getstream.video.android.core.StreamVideoClient
 import io.getstream.video.android.core.notifications.NotificationType
 import io.getstream.video.android.core.notifications.internal.Throttler
@@ -57,25 +55,25 @@ import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 
-internal class ServiceLauncher(val context: Context) {
+internal class ServiceLauncher(private val client: StreamVideoClient) {
 
     private val logger by taggedLogger("ServiceTriggers")
+
+    private val context = client.context
     private val serviceIntentBuilder = ServiceIntentBuilder()
-    private val incomingCallPresenter = IncomingCallPresenter(serviceIntentBuilder)
+    private val incomingCallPresenter = IncomingCallPresenter(client, serviceIntentBuilder)
     private val telecomHelper = TelecomHelper()
     private val telecomPermissions = TelecomPermissions()
-    private val jetpackTelecomRepositoryProvider = JetpackTelecomRepositoryProvider(context)
+    private val jetpackTelecomRepositoryProvider = JetpackTelecomRepositoryProvider(client)
     private val throttler = Throttler()
 
     @SuppressLint("MissingPermission", "NewApi")
     fun showIncomingCall(
-        context: Context,
         callId: StreamCallId,
         callDisplayName: String?,
         callServiceConfiguration: CallServiceConfig,
         isVideo: Boolean,
         payload: Map<String, Any?>,
-        streamVideo: StreamVideo,
         notification: Notification?,
     ) {
         val result = incomingCallPresenter.showIncomingCall(
@@ -90,15 +88,15 @@ internal class ServiceLauncher(val context: Context) {
             if (telecomHelper.canUseJetpackTelecom()) {
                 when (result) {
                     ShowIncomingCallResult.FG_SERVICE -> {
-                        updateIncomingCallNotification(notification, streamVideo, callId)
+                        updateIncomingCallNotification(notification, callId)
 
                         val jetpackTelecomRepository = jetpackTelecomRepositoryProvider.get(callId)
 
-                        val appSchema = (streamVideo as StreamVideoClient).telecomConfig?.schema
+                        val appSchema = client.telecomConfig?.schema
                         val addressUri = "$appSchema:${callId.id}".toUri()
                         val formattedCallDisplayName = callDisplayName?.takeIf { it.isNotBlank() } ?: DEFAULT_CALL_TEXT
 
-                        val call = streamVideo.call(callId.type, callId.id)
+                        val call = client.call(callId.type, callId.id)
 
                         call.state.jetpackTelecomRepository = (jetpackTelecomRepository)
 
@@ -117,14 +115,12 @@ internal class ServiceLauncher(val context: Context) {
         }
     }
 
-    fun showOnGoingCall(call: Call, trigger: String, streamVideo: StreamVideo) {
-        val client = streamVideo as StreamVideoClient
+    fun showOnGoingCall(call: Call, trigger: String) {
         val callConfig = client.callServiceConfigRegistry.get(call.type)
         if (!callConfig.runCallServiceInForeground) {
             return
         }
         val callId = StreamCallId.fromCallCid(call.cid)
-        val context = client.context
         val serviceIntent = ServiceIntentBuilder().buildStartIntent(
             context,
             StartServiceParam(
@@ -137,8 +133,8 @@ internal class ServiceLauncher(val context: Context) {
     }
 
     @SuppressLint("NewApi")
-    fun showOutgoingCall(call: Call, trigger: String, streamVideo: StreamVideo) {
-        val callConfig = (streamVideo as StreamVideoClient).callServiceConfigRegistry.get(call.type)
+    fun showOutgoingCall(call: Call, trigger: String) {
+        val callConfig = client.callServiceConfigRegistry.get(call.type)
         if (!callConfig.runCallServiceInForeground) {
             return
         }
@@ -159,13 +155,11 @@ internal class ServiceLauncher(val context: Context) {
          */
         val callDisplayName = "NOT SET YET"
 
-        val telecomPermissions = TelecomPermissions()
-        val telecomHelper = TelecomHelper()
         if (telecomPermissions.canUseTelecom(callConfig, context)) {
             if (telecomHelper.canUseJetpackTelecom()) {
                 val jetpackTelecomRepository = jetpackTelecomRepositoryProvider.get(callId)
 
-                val appSchema = streamVideo.telecomConfig?.schema
+                val appSchema = client.telecomConfig?.schema
                 val addressUri = "$appSchema:${callId.id}".toUri()
                 val formattedCallDisplayName =
                     callDisplayName?.takeIf { it.isNotBlank() } ?: DEFAULT_CALL_TEXT
@@ -199,18 +193,16 @@ internal class ServiceLauncher(val context: Context) {
      */
     private fun updateIncomingCallNotification(
         notification: Notification?,
-        streamVideo: StreamVideo,
         callId: StreamCallId,
     ) {
         notification?.let {
             val notificationId = callId.getNotificationId(NotificationType.Incoming)
-            streamVideo.call(callId.type, callId.id)
+            client.call(callId.type, callId.id)
                 .state.updateNotification(notificationId, notification)
         }
     }
 
     fun removeIncomingCall(
-        context: Context,
         callId: StreamCallId,
         config: CallServiceConfig = DefaultCallConfigurations.default,
     ) {
@@ -249,25 +241,18 @@ internal class ServiceLauncher(val context: Context) {
 
     private fun stopCallServiceInternal(call: Call) {
         logger.d { "[stopCallServiceInternal]" }
-        val streamVideo = StreamVideo.instanceOrNull() as? StreamVideoClient
-        streamVideo?.let { streamVideoClient ->
-            val callConfig = streamVideoClient.callServiceConfigRegistry.get(call.type)
-            if (callConfig.runCallServiceInForeground) {
-                val context = streamVideoClient.context
-
-                val serviceIntent = serviceIntentBuilder.buildStopIntent(
-                    context,
-                    StopServiceParam(call, callConfig),
-                )
-                serviceIntent?.let {
-                    logger.d {
-                        "Building stop intent, class: ${serviceIntent.component?.className} for call_id: ${call.cid}"
-                    }
-                    serviceIntent.extras?.let {
-                        logBundle(it)
-                    }
-                    context.startService(serviceIntent)
+        val callConfig = client.callServiceConfigRegistry.get(call.type)
+        if (callConfig.runCallServiceInForeground) {
+            val serviceIntent = serviceIntentBuilder.buildStopIntent(
+                context,
+                StopServiceParam(call, callConfig),
+            )
+            serviceIntent?.let {
+                logger.d {
+                    "Building stop intent, class: ${serviceIntent.component?.className} for call_id: ${call.cid}"
                 }
+                serviceIntent.extras?.let { logBundle(it) }
+                context.startService(serviceIntent)
             }
         }
     }

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/telecom/TelecomHelper.kt

@@ -19,6 +19,7 @@
 import android.os.Build
 import io.getstream.video.android.core.StreamVideo
 
+// TODO pass StreamVideo instance in constructor on v2
 internal class TelecomHelper {
 
     fun canUseJetpackTelecom(): Boolean {

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/telecom/TelecomPermissions.kt

@@ -27,6 +27,7 @@
 import io.getstream.video.android.core.StreamVideoClient
 import io.getstream.video.android.core.notifications.internal.service.CallServiceConfig
 
+// TODO pass StreamVideo instance in constructor on v2
 class TelecomPermissions {
 
     private val logger: TaggedLogger by taggedLogger("TelecomPermissions")