Skip to content

Fix back navigation in demo-app in call-activity - #1829

Merged
aleksandar-apostolov merged 2 commits into
developfrom
demo-app/call-activity-back-navigation
Sep 11, 2026
Merged

Fix back navigation in demo-app in call-activity#1829
aleksandar-apostolov merged 2 commits into
developfrom
demo-app/call-activity-back-navigation

Conversation

@rahul-lohra

@rahul-lohra rahul-lohra commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Goal

Closes AND-1526
Fix back navigation in demo-app in call-activity

Implementation

Fix back navigation in demo-app in call-activity

🎨 UI Changes

None

Testing

Smoke test with join error

Summary by CodeRabbit

  • Bug Fixes
    • Improved activity navigation when closing a call screen, ensuring the main screen is restored correctly when needed.
    • Simplified back-navigation handling to provide more consistent behavior when finishing the activity.

@rahul-lohra rahul-lohra self-assigned this Sep 11, 2026
@rahul-lohra
rahul-lohra requested a review from a team as a code owner September 11, 2026 12:36
@rahul-lohra rahul-lohra added the pr:demo-app Changes specific to demo app label Sep 11, 2026
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
  • An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 2ede52ae-260b-4754-8faa-d50fe55f8ea6

📥 Commits

Reviewing files that changed from the base of the PR and between 0822b4c and bc52fc5.

📒 Files selected for processing (1)
  • demo-app/src/main/kotlin/io/getstream/video/android/CallActivity.kt

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

CallActivity moves main-activity relaunch logic from goBackToMainScreen() into the finish() override.

Changes

CallActivity navigation

Layer / File(s) Summary
Centralize finish handling
demo-app/src/main/kotlin/io/getstream/video/android/CallActivity.kt
goBackToMainScreen() now calls safeFinish(). finish() launches MainActivity for a non-finishing task root before calling super.finish().

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: aleksandar-apostolov

Merge Risk: ⚪ Minimal · up to bc52f

The navigation change is ready to merge based on the available evidence.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the back-navigation fix in the demo app call activity.
Description check ✅ Passed The description includes the goal, implementation, UI status, and testing information. It omits the contributor and reviewer checklist, but the core change and validation details are clear.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch demo-app/call-activity-back-navigation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit hops through finish’s door
MainActivity waits on the floor
SafeFinish keeps the pathway bright
Task roots now relaunch just right
Carrots cheer the cleaner flight

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 12.38 MB 12.38 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.23 MB 6.23 MB 0.00 MB 🟢

@rahul-lohra rahul-lohra changed the title Fix back navigation in demo-app in call-activity [AND-1526] Fix back navigation in demo-app in call-activity Sep 11, 2026
@rahul-lohra rahul-lohra changed the title [AND-1526] Fix back navigation in demo-app in call-activity Fix back navigation in demo-app in call-activity Sep 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

@aleksandar-apostolov
aleksandar-apostolov merged commit 474179e into develop Sep 11, 2026
18 of 21 checks passed
@aleksandar-apostolov
aleksandar-apostolov deleted the demo-app/call-activity-back-navigation branch September 11, 2026 13:04
@stream-public-bot stream-public-bot added the released Included in a release label Sep 11, 2026
@stream-public-bot

Copy link
Copy Markdown
Collaborator

🚀 Available in v1.33.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:demo-app Changes specific to demo app released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants