Resolve race condition when injecting floodgate handler#651
Merged
Conversation
Kas-tle
approved these changes
Feb 22, 2026
Member
Author
|
Tested on Paper 1.21.11, 1.16.5, and also 1.8.9 + Geyser-Standalone; seems to work fine. Will merge on Thursday if no further issues will be reported by other testers |
Tim203
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve a long-standing issue where floodgate-spigot was "late" to the party, especially when used alongside Geyser-Spigot.
Initial debugging (see this gist ) shows a case where netty fired
channelActivebefore Floodgate finished its injection process.With Geyser's
use-direct-connectionfeature, MCPL receives thischannelActivecall, which resulted in MCPL firing aConnectedEvent), which in turn is used by theClientListenerto start the auth process by sending a packet that floodgate is supposed to intercept. However, Floodgate wasn't able to due to the injection not being completed in some occurrences at that time.Here is a log showing which events are fired with this patch. I've tested it locally and am no longer able to reproduce the issue with this patch - without it, it occurred about once every 4-5 joins.
Resolves #530,
Resolves GeyserMC/Geyser#5086,
Resolves GeyserMC/Geyser#5828,
Resolves GeyserMC/Geyser#5975,
Resolves GeyserMC/Geyser#4403,
likely also #598