improvement: merge :root rules, implements #16#39
Open
mod3x wants to merge 1 commit intoGoogleChromeLabs:mainfrom
Open
improvement: merge :root rules, implements #16#39mod3x wants to merge 1 commit intoGoogleChromeLabs:mainfrom
mod3x wants to merge 1 commit intoGoogleChromeLabs:mainfrom
Conversation
Contributor
|
interesting strategy of consolidation as a post processing step. i had assumed a "resume state" strategy would be best, like finding an existing some additional test ideas:
Seems clear that a "understand the state of the world for custom props in this project" is important for this functionality. Either doing that up front or as a post process. Thanks for hackin on this, let me know how else I can provide some assistance 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. This PR is an attempt to resolve issue #16. Currently, it merges :root rules in the OnceExit listener when all mutations are completed. However, I'm concerned that this solution may be too simplistic. Additionally, I've only added one test case, which I don't think is enough. Let's discuss this further and try to find a better solution. Thank you.